Source/core/rendering/RenderTextControlSingleLine.cpp - Issue 236203020: Separate repaint and layout requirements of StyleDifference (Step 1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderTextControlSingleLine.cpp

Issue 236203020: Separate repaint and layout requirements of StyleDifference (Step 1) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase; Renaming of some methods and small changes in StyleDifference Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderTextControlSingleLine.cpp

diff --git a/Source/core/rendering/RenderTextControlSingleLine.cpp b/Source/core/rendering/RenderTextControlSingleLine.cpp

index 45278ad08f7942ae2c6e87cb389b334be633ad42..1ec7946e893e83459ba8fd8c502677596fb5f334 100644

--- a/Source/core/rendering/RenderTextControlSingleLine.cpp

+++ b/Source/core/rendering/RenderTextControlSingleLine.cpp

@@ -238,7 +238,7 @@ void RenderTextControlSingleLine::styleDidChange(StyleDifference diff, const Ren

containerRenderer->style()->setWidth(Length());

}

RenderObject* innerTextRenderer = innerTextElement()->renderer();

- if (innerTextRenderer && diff == StyleDifferenceLayout)

+ if (innerTextRenderer && diff.needsFullLayout())

innerTextRenderer->setNeedsLayout();

if (HTMLElement* placeholder = inputElement()->placeholderElement())

placeholder->setInlineStyleProperty(CSSPropertyTextOverflow, textShouldBeTruncated() ? CSSValueEllipsis : CSSValueClip);