Chromium Code Reviews

Side by Side Diff: Source/core/rendering/RenderLayer.cpp

Issue 236203020: Separate repaint and layout requirements of StyleDifference (Step 1) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update layout test expectations Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 3821 matching lines...)
3832 3832
3833 void RenderLayer::styleChanged(StyleDifference diff, const RenderStyle* oldStyle ) 3833 void RenderLayer::styleChanged(StyleDifference diff, const RenderStyle* oldStyle )
3834 { 3834 {
3835 m_stackingNode->updateIsNormalFlowOnly(); 3835 m_stackingNode->updateIsNormalFlowOnly();
3836 m_stackingNode->updateStackingNodesAfterStyleChange(oldStyle); 3836 m_stackingNode->updateStackingNodesAfterStyleChange(oldStyle);
3837 3837
3838 if (m_scrollableArea) 3838 if (m_scrollableArea)
3839 m_scrollableArea->updateAfterStyleChange(oldStyle); 3839 m_scrollableArea->updateAfterStyleChange(oldStyle);
3840 3840
3841 if (!oldStyle || oldStyle->visibility() != renderer()->style()->visibility() ) { 3841 if (!oldStyle || oldStyle->visibility() != renderer()->style()->visibility() ) {
3842 ASSERT(!oldStyle || diff >= StyleDifferenceRepaint); 3842 ASSERT(!oldStyle || diff.needsRepaint());
3843 compositor()->setNeedsUpdateCompositingRequirementsState(); 3843 compositor()->setNeedsUpdateCompositingRequirementsState();
3844 } 3844 }
3845 3845
3846 // Overlay scrollbars can make this layer self-painting so we need 3846 // Overlay scrollbars can make this layer self-painting so we need
3847 // to recompute the bit once scrollbars have been updated. 3847 // to recompute the bit once scrollbars have been updated.
3848 updateSelfPaintingLayer(); 3848 updateSelfPaintingLayer();
3849 3849
3850 if (!oldStyle || renderer()->style()->position() != oldStyle->position()) { 3850 if (!oldStyle || renderer()->style()->position() != oldStyle->position()) {
3851 ASSERT(!oldStyle || diff >= StyleDifferenceLayout); 3851 ASSERT(!oldStyle || diff.needsFullLayout());
3852 updateOutOfFlowPositioned(oldStyle); 3852 updateOutOfFlowPositioned(oldStyle);
3853 } 3853 }
3854 3854
3855 if (!oldStyle || !renderer()->style()->reflectionDataEquivalent(oldStyle)) { 3855 if (!oldStyle || !renderer()->style()->reflectionDataEquivalent(oldStyle)) {
3856 ASSERT(!oldStyle || diff >= StyleDifferenceLayout); 3856 ASSERT(!oldStyle || diff.needsFullLayout());
3857 updateReflectionInfo(oldStyle); 3857 updateReflectionInfo(oldStyle);
3858 } 3858 }
3859 3859
3860 if (RuntimeEnabledFeatures::cssCompositingEnabled()) 3860 if (RuntimeEnabledFeatures::cssCompositingEnabled())
3861 m_blendInfo.updateBlendMode(); 3861 m_blendInfo.updateBlendMode();
3862 3862
3863 updateDescendantDependentFlags(); 3863 updateDescendantDependentFlags();
3864 3864
3865 if (!oldStyle || !renderer()->style()->transformDataEquivalent(*oldStyle)) 3865 if (!oldStyle || !renderer()->style()->transformDataEquivalent(*oldStyle))
3866 updateTransform(); 3866 updateTransform();
(...skipping 180 matching lines...)
4047 } 4047 }
4048 } 4048 }
4049 4049
4050 void showLayerTree(const WebCore::RenderObject* renderer) 4050 void showLayerTree(const WebCore::RenderObject* renderer)
4051 { 4051 {
4052 if (!renderer) 4052 if (!renderer)
4053 return; 4053 return;
4054 showLayerTree(renderer->enclosingLayer()); 4054 showLayerTree(renderer->enclosingLayer());
4055 } 4055 }
4056 #endif 4056 #endif
OLDNEW

Powered by Google App Engine