Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: Source/core/rendering/svg/RenderSVGRoot.cpp

Issue 236203020: Separate repaint and layout requirements of StyleDifference (Step 1) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase, Fix break Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007, 2008, 2009 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007, 2008, 2009 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2009 Google, Inc. 5 * Copyright (C) 2009 Google, Inc.
6 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
275 void RenderSVGRoot::willBeDestroyed() 275 void RenderSVGRoot::willBeDestroyed()
276 { 276 {
277 RenderBlock::removePercentHeightDescendant(const_cast<RenderSVGRoot*>(this)) ; 277 RenderBlock::removePercentHeightDescendant(const_cast<RenderSVGRoot*>(this)) ;
278 278
279 SVGResourcesCache::clientDestroyed(this); 279 SVGResourcesCache::clientDestroyed(this);
280 RenderReplaced::willBeDestroyed(); 280 RenderReplaced::willBeDestroyed();
281 } 281 }
282 282
283 void RenderSVGRoot::styleDidChange(StyleDifference diff, const RenderStyle* oldS tyle) 283 void RenderSVGRoot::styleDidChange(StyleDifference diff, const RenderStyle* oldS tyle)
284 { 284 {
285 if (diff == StyleDifferenceLayout) 285 if (diff.needsFullLayout())
286 setNeedsBoundariesUpdate(); 286 setNeedsBoundariesUpdate();
287 if (diff == StyleDifferenceRepaint) { 287 // FIXME: How about other diff flags?
288 if (diff.needsRepaintObjectOnly()) {
288 // Box decorations may have appeared/disappeared - recompute status. 289 // Box decorations may have appeared/disappeared - recompute status.
289 m_hasBoxDecorations = calculateHasBoxDecorations(); 290 m_hasBoxDecorations = calculateHasBoxDecorations();
290 } 291 }
291 292
292 RenderReplaced::styleDidChange(diff, oldStyle); 293 RenderReplaced::styleDidChange(diff, oldStyle);
293 SVGResourcesCache::clientStyleChanged(this, diff, style()); 294 SVGResourcesCache::clientStyleChanged(this, diff, style());
294 } 295 }
295 296
296 bool RenderSVGRoot::isChildAllowed(RenderObject* child, RenderStyle*) const 297 bool RenderSVGRoot::isChildAllowed(RenderObject* child, RenderStyle*) const
297 { 298 {
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
452 updateHitTestResult(result, pointInBorderBox); 453 updateHitTestResult(result, pointInBorderBox);
453 if (!result.addNodeToRectBasedTestResult(node(), request, locationIn Container, boundsRect)) 454 if (!result.addNodeToRectBasedTestResult(node(), request, locationIn Container, boundsRect))
454 return true; 455 return true;
455 } 456 }
456 } 457 }
457 458
458 return false; 459 return false;
459 } 460 }
460 461
461 } 462 }
OLDNEW
« no previous file with comments | « Source/core/rendering/svg/RenderSVGResourceFilterPrimitive.cpp ('k') | Source/core/rendering/svg/SVGInlineTextBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698