Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Side by Side Diff: Source/core/rendering/RenderTableRow.cpp

Issue 236203020: Separate repaint and layout requirements of StyleDifference (Step 1) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase, Fix break Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderScrollbarPart.cpp ('k') | Source/core/rendering/RenderText.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 72
73 if (section() && oldStyle && style()->logicalHeight() != oldStyle->logicalHe ight()) 73 if (section() && oldStyle && style()->logicalHeight() != oldStyle->logicalHe ight())
74 section()->rowLogicalHeightChanged(rowIndex()); 74 section()->rowLogicalHeightChanged(rowIndex());
75 75
76 // If border was changed, notify table. 76 // If border was changed, notify table.
77 if (parent()) { 77 if (parent()) {
78 RenderTable* table = this->table(); 78 RenderTable* table = this->table();
79 if (table && !table->selfNeedsLayout() && !table->normalChildNeedsLayout () && oldStyle && oldStyle->border() != style()->border()) 79 if (table && !table->selfNeedsLayout() && !table->normalChildNeedsLayout () && oldStyle && oldStyle->border() != style()->border())
80 table->invalidateCollapsedBorders(); 80 table->invalidateCollapsedBorders();
81 81
82 if (table && oldStyle && diff == StyleDifferenceLayout && needsLayout() && table->collapseBorders() && borderWidthChanged(oldStyle, style())) { 82 if (table && oldStyle && diff.needsFullLayout() && needsLayout() && tabl e->collapseBorders() && borderWidthChanged(oldStyle, style())) {
83 // If the border width changes on a row, we need to make sure the ce lls in the row know to lay out again. 83 // If the border width changes on a row, we need to make sure the ce lls in the row know to lay out again.
84 // This only happens when borders are collapsed, since they end up a ffecting the border sides of the cell 84 // This only happens when borders are collapsed, since they end up a ffecting the border sides of the cell
85 // itself. 85 // itself.
86 for (RenderBox* childBox = firstChildBox(); childBox; childBox = chi ldBox->nextSiblingBox()) { 86 for (RenderBox* childBox = firstChildBox(); childBox; childBox = chi ldBox->nextSiblingBox()) {
87 if (!childBox->isTableCell()) 87 if (!childBox->isTableCell())
88 continue; 88 continue;
89 childBox->setChildNeedsLayout(); 89 childBox->setChildNeedsLayout();
90 } 90 }
91 } 91 }
92 } 92 }
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 264
265 RenderTableRow* RenderTableRow::createAnonymousWithParentRenderer(const RenderOb ject* parent) 265 RenderTableRow* RenderTableRow::createAnonymousWithParentRenderer(const RenderOb ject* parent)
266 { 266 {
267 RenderTableRow* newRow = RenderTableRow::createAnonymous(&parent->document() ); 267 RenderTableRow* newRow = RenderTableRow::createAnonymous(&parent->document() );
268 RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyleWithDisplay( parent->style(), TABLE_ROW); 268 RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyleWithDisplay( parent->style(), TABLE_ROW);
269 newRow->setStyle(newStyle.release()); 269 newRow->setStyle(newStyle.release());
270 return newRow; 270 return newRow;
271 } 271 }
272 272
273 } // namespace WebCore 273 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderScrollbarPart.cpp ('k') | Source/core/rendering/RenderText.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698