Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Side by Side Diff: Source/core/rendering/RenderLayer.cpp

Issue 236203020: Separate repaint and layout requirements of StyleDifference (Step 1) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase, Fix break Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 3779 matching lines...) Expand 10 before | Expand all | Expand 10 after
3790 3790
3791 void RenderLayer::styleChanged(StyleDifference diff, const RenderStyle* oldStyle ) 3791 void RenderLayer::styleChanged(StyleDifference diff, const RenderStyle* oldStyle )
3792 { 3792 {
3793 m_stackingNode->updateIsNormalFlowOnly(); 3793 m_stackingNode->updateIsNormalFlowOnly();
3794 m_stackingNode->updateStackingNodesAfterStyleChange(oldStyle); 3794 m_stackingNode->updateStackingNodesAfterStyleChange(oldStyle);
3795 3795
3796 if (m_scrollableArea) 3796 if (m_scrollableArea)
3797 m_scrollableArea->updateAfterStyleChange(oldStyle); 3797 m_scrollableArea->updateAfterStyleChange(oldStyle);
3798 3798
3799 if (!oldStyle || oldStyle->visibility() != renderer()->style()->visibility() ) { 3799 if (!oldStyle || oldStyle->visibility() != renderer()->style()->visibility() ) {
3800 ASSERT(!oldStyle || diff >= StyleDifferenceRepaint); 3800 ASSERT(!oldStyle || diff.needsRepaint() || diff.needsLayout());
3801 compositor()->setNeedsUpdateCompositingRequirementsState(); 3801 compositor()->setNeedsUpdateCompositingRequirementsState();
3802 } 3802 }
3803 3803
3804 // Overlay scrollbars can make this layer self-painting so we need 3804 // Overlay scrollbars can make this layer self-painting so we need
3805 // to recompute the bit once scrollbars have been updated. 3805 // to recompute the bit once scrollbars have been updated.
3806 updateSelfPaintingLayer(); 3806 updateSelfPaintingLayer();
3807 3807
3808 if (!oldStyle || renderer()->style()->position() != oldStyle->position()) { 3808 if (!oldStyle || renderer()->style()->position() != oldStyle->position()) {
3809 ASSERT(!oldStyle || diff >= StyleDifferenceLayout); 3809 ASSERT(!oldStyle || diff.needsFullLayout());
3810 updateOutOfFlowPositioned(oldStyle); 3810 updateOutOfFlowPositioned(oldStyle);
3811 } 3811 }
3812 3812
3813 if (!oldStyle || !renderer()->style()->reflectionDataEquivalent(oldStyle)) { 3813 if (!oldStyle || !renderer()->style()->reflectionDataEquivalent(oldStyle)) {
3814 ASSERT(!oldStyle || diff >= StyleDifferenceLayout); 3814 ASSERT(!oldStyle || diff.needsFullLayout());
3815 updateReflectionInfo(oldStyle); 3815 updateReflectionInfo(oldStyle);
3816 } 3816 }
3817 3817
3818 if (RuntimeEnabledFeatures::cssCompositingEnabled()) 3818 if (RuntimeEnabledFeatures::cssCompositingEnabled())
3819 m_blendInfo.updateBlendMode(); 3819 m_blendInfo.updateBlendMode();
3820 3820
3821 updateDescendantDependentFlags(); 3821 updateDescendantDependentFlags();
3822 3822
3823 if (!oldStyle || !renderer()->style()->transformDataEquivalent(*oldStyle)) 3823 if (!oldStyle || !renderer()->style()->transformDataEquivalent(*oldStyle))
3824 updateTransform(); 3824 updateTransform();
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
4003 } 4003 }
4004 } 4004 }
4005 4005
4006 void showLayerTree(const WebCore::RenderObject* renderer) 4006 void showLayerTree(const WebCore::RenderObject* renderer)
4007 { 4007 {
4008 if (!renderer) 4008 if (!renderer)
4009 return; 4009 return;
4010 showLayerTree(renderer->enclosingLayer()); 4010 showLayerTree(renderer->enclosingLayer());
4011 } 4011 }
4012 #endif 4012 #endif
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderFlexibleBox.cpp ('k') | Source/core/rendering/RenderLayerModelObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698