win: Implement Bluetooth server.

net/base/net_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/net_util.h"
 
 #include <errno.h>
 
 #include <algorithm>
 #include <iterator>
 #include <map>
 #include <set>
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <iphlpapi.h>
 #include <winsock2.h>
+#include <ws2bth.h>
 #pragma comment(lib, "iphlpapi.lib")
 #elif defined(OS_POSIX)
 #include <fcntl.h>
 #include <netdb.h>
 #include <netinet/in.h>
 #if !defined(OS_NACL)
 #include <net/if.h>
 #if !defined(OS_ANDROID)
 #include <ifaddrs.h>
 #endif  // !defined(OS_NACL)
@@ skipping 1129 matching lines @@
     return false;
   size_t width = host_addr.size() + 1;
   for (size_t i = 0; i < array_size; ++i, array += width) {
     if (IPNumberPrefixCheck(host_addr, array, array[width-1]))
       return true;
   }
   return false;
 }
 
 // Extracts the address and port portions of a sockaddr.
 bool GetIPAddressFromSockAddr(const struct sockaddr* sock_addr,

[wtc, 2014/04/24 23:09:31]

I don't see any call to GetIPAddressFromSockAddr in this CL. Can you explain why
GetIPAddressFromSockAddr needs to be modified?

[xiyuan, 2014/04/25 20:29:29]

It is indirectly called in ip_end_point.FromSockAddr(...) in
TCPSocketWin::AcceptInternal to obtain the peer address.

https://code.google.com/p/chromium/codesearch#chromium/src/net/socket/tcp_soc...

The peer address is later used in BluetoothProfileWin::OnNewConnection to find
the corresponding Bth device.

                               socklen_t sock_addr_len,
                               const uint8** address,
                               size_t* address_len,
                               uint16* port) {
   if (sock_addr->sa_family == AF_INET) {
     if (sock_addr_len < static_cast<socklen_t>(sizeof(struct sockaddr_in)))
       return false;
     const struct sockaddr_in* addr =
         reinterpret_cast<const struct sockaddr_in*>(sock_addr);
     *address = reinterpret_cast<const uint8*>(&addr->sin_addr);
     *address_len = kIPv4AddressSize;
     if (port)
       *port = base::NetToHost16(addr->sin_port);
     return true;
   }
 
   if (sock_addr->sa_family == AF_INET6) {
     if (sock_addr_len < static_cast<socklen_t>(sizeof(struct sockaddr_in6)))
       return false;
     const struct sockaddr_in6* addr =
         reinterpret_cast<const struct sockaddr_in6*>(sock_addr);
     *address = reinterpret_cast<const unsigned char*>(&addr->sin6_addr);

[wtc, 2014/04/24 23:09:31]

Nit: could you change "unsigned char" to "uint8" here for consistency?

[xiyuan, 2014/04/25 20:29:29]

Done.

     *address_len = kIPv6AddressSize;
     if (port)
       *port = base::NetToHost16(addr->sin6_port);
     return true;
   }
 
+#if defined(OS_WIN)
+  // Bluetooth address size. Windows bluetooth is supported via winsock.

[wtc, 2014/04/24 23:09:31]

Nit: capitalize "bluetooth".

[xiyuan, 2014/04/25 20:29:29]

Done.

+  const size_t kBtAddressSize = 6;

[wtc, 2014/04/24 23:09:31]

1. Nit: it seems better to use "Bth" instead of "Bt" because the address family
macro is "AF_BTH".

2. It seems that this constant should be defined in the net/base/net_util.h
header instead (inside #if defined(OS_WIN)). You also need this constant in
device/bluetooth/bluetooth_profile_win.cc.

[xiyuan, 2014/04/25 20:29:29]

Done.
Done.

+  if (sock_addr->sa_family == AF_BTH) {
+    if (sock_addr_len < static_cast<socklen_t>(sizeof(SOCKADDR_BTH)))
+      return false;
+    const SOCKADDR_BTH* addr =
+        reinterpret_cast<const SOCKADDR_BTH*>(sock_addr);
+    *address = reinterpret_cast<const uint8*>(&addr->btAddr);
+    *address_len = kBtAddressSize;
+    if (port)
+      *port = addr->port;

[wtc, 2014/04/24 23:09:31]

This doesn't extract the serviceClassId member of SOCKADDR_BTH. Is that a
problem?

[xiyuan, 2014/04/25 20:29:29]

serviceClassId is a way to map to a port(aka Bt channel). We use port directly
so don't need this.

+    return true;
+  }
+#endif
+
   return false;  // Unrecognized |sa_family|.
 }
 
 std::string IPAddressToString(const uint8* address,
                               size_t address_len) {
   std::string str;
   url_canon::StdStringCanonOutput output(&str);
 
   if (address_len == kIPv4AddressSize) {
     url_canon::AppendIPv4Address(address, &output);
@@ skipping 625 matching lines @@
   }
   return a1.size() * CHAR_BIT;
 }
 
 unsigned MaskPrefixLength(const IPAddressNumber& mask) {
   IPAddressNumber all_ones(mask.size(), 0xFF);
   return CommonPrefixLength(mask, all_ones);
 }
 
 }  // namespace net