Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: ui/accessibility/ax_tree_update.cc

Issue 236203015: Add ToString to AXTreeUpdate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/accessibility/ax_tree_update.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/accessibility/ax_tree_update.cc
diff --git a/ui/accessibility/ax_tree_update.cc b/ui/accessibility/ax_tree_update.cc
index dc785d9e06ee3d8947a1579f6860496690533dca..642bc0c61b0bbe9a7ff48cdd4e7d1a56e8d0e22a 100644
--- a/ui/accessibility/ax_tree_update.cc
+++ b/ui/accessibility/ax_tree_update.cc
@@ -4,6 +4,9 @@
#include "ui/accessibility/ax_tree_update.h"
+#include "base/containers/hash_tables.h"
+#include "base/strings/string_number_conversions.h"
+
namespace ui {
AXTreeUpdate::AXTreeUpdate() : node_id_to_clear(0) {
@@ -12,4 +15,29 @@ AXTreeUpdate::AXTreeUpdate() : node_id_to_clear(0) {
AXTreeUpdate::~AXTreeUpdate() {
}
+std::string AXTreeUpdate::ToString() const {
+ std::string result;
+ if (node_id_to_clear != 0) {
+ result += "AXTreeUpdate: clear node " +
+ base::IntToString(node_id_to_clear) + "\n";
+ }
+
+ // The challenge here is that we want to indent the nodes being updated
+ // so that parent/child relationships are clear, but we don't have access
+ // to the rest of the tree for context, so we have to try to show the
+ // relative indentation of child nodes in this update relative to their
+ // parents.
+ base::hash_map<int32, int> id_to_indentation;
+ for (size_t i = 0; i < nodes.size(); ++i) {
+ int indent = id_to_indentation[nodes[i].id];
+ for (int j = 0; j < indent; ++j)
+ result += " ";
aboxhall 2014/04/16 02:02:42 Optionally you could replace these two lines with
dmazzoni 2014/04/16 05:06:39 Thanks! I always forget about that constructor.
+ result += nodes[i].ToString() + "\n";
+ for (size_t j = 0; j < nodes[i].child_ids.size(); ++j)
+ id_to_indentation[nodes[i].child_ids[j]] = indent + 1;
+ }
+
+ return result;
+}
+
} // namespace ui
« no previous file with comments | « ui/accessibility/ax_tree_update.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698