Issue 236203015: Add ToString to AXTreeUpdate.

Issue 236203015: Add ToString to AXTreeUpdate. (Closed)

Created:
6 years, 8 months ago by dmazzoni

Modified:
6 years, 8 months ago

Reviewers:
aboxhall

CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add ToString to AXTreeUpdate. We need this for decent log messages in renderer_accessibility_complete.cc. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264182

Patch Set 2 : Nicer indent #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -7 lines)			Patch
M	content/renderer/accessibility/renderer_accessibility_complete.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	ui/accessibility/ax_node_data.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/accessibility/ax_tree.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	ui/accessibility/ax_tree_unittest.cc	View		1 chunk	+38 lines, -0 lines	0 comments	Download
M	ui/accessibility/ax_tree_update.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/accessibility/ax_tree_update.cc	View	1	2 chunks	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

aboxhall

lgtm https://codereview.chromium.org/236203015/diff/1/ui/accessibility/ax_tree_update.cc File ui/accessibility/ax_tree_update.cc (right): https://codereview.chromium.org/236203015/diff/1/ui/accessibility/ax_tree_update.cc#newcode34 ui/accessibility/ax_tree_update.cc:34: result += " "; Optionally you could replace ...

6 years, 8 months ago (2014-04-16 02:02:41 UTC) #2

dmazzoni

https://codereview.chromium.org/236203015/diff/1/ui/accessibility/ax_tree_update.cc File ui/accessibility/ax_tree_update.cc (right): https://codereview.chromium.org/236203015/diff/1/ui/accessibility/ax_tree_update.cc#newcode34 ui/accessibility/ax_tree_update.cc:34: result += " "; On 2014/04/16 02:02:42, aboxhall wrote: ...

6 years, 8 months ago (2014-04-16 05:06:39 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/236203015/20001

6 years, 8 months ago (2014-04-16 05:07:40 UTC) #5

Message was sent while issue was closed.

Change committed as 264182

Expand Messages | Collapse Messages