Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 23620042: Revert 222689 "Use an X event loop in the GPU process on Linux." (Closed)

Created:
7 years, 3 months ago by DaleCurtis
Modified:
7 years, 3 months ago
Reviewers:
ccameron
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 222689 "Use an X event loop in the GPU process on Linux." > Use an X event loop in the GPU process on Linux. > > In future patches, X windows will be created in the GPU > process, and events sent to these windows will need to > be forwarded to their parent windows. > > Linux uses GTK as the default UI event loop type, but > GTK is not in the GPU process, so the X11 event loop > type is used instead. > > Update package dependencies. > > BUG=145600 > TBR=thakis, piman > > Review URL: https://chromiumcodereview.appspot.com/23710029 Broke nacl-sizes: PERF_REGRESS: nacl_helper-text/text (0.11%), nacl_helper-text/text (0.11%) http://build.chromium.org/p/chromium/buildstatus?builder=Linux%20x64&number=55508 Please add a suppression or remove the inclusion from nacl_helper. TBR=ccameron@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222694

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -39 lines) Patch
M trunk/src/base/message_loop/message_loop.h View 5 chunks +1 line, -19 lines 0 comments Download
M trunk/src/base/message_loop/message_loop.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/base/message_loop/message_pump_x11.h View 1 chunk +3 lines, -1 line 0 comments Download
M trunk/src/base/message_loop/message_pump_x11.cc View 1 chunk +1 line, -7 lines 0 comments Download
M trunk/src/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/installer/linux/debian/expected_deps View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/installer/linux/rpm/expected_deps_i386 View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/installer/linux/rpm/expected_deps_x86_64 View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/gpu/gpu_main.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
DaleCurtis
7 years, 3 months ago (2013-09-12 01:49:21 UTC) #1
DaleCurtis
7 years, 3 months ago (2013-09-12 01:49:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r222694.

Powered by Google App Engine
This is Rietveld 408576698