Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Unified Diff: Source/core/loader/FrameLoader.h

Issue 23620020: Don't wait to notify client of spoof attempt if a modal dialog is created. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use PageGroupLoadDeferrer instead Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/FrameLoader.h
diff --git a/Source/core/loader/FrameLoader.h b/Source/core/loader/FrameLoader.h
index 0ac5e38ee8b89edc63e8ae47b0cba006334ddbde..a5005154879d5874ab114f92ad570982f73c09c3 100644
--- a/Source/core/loader/FrameLoader.h
+++ b/Source/core/loader/FrameLoader.h
@@ -111,8 +111,15 @@ public:
// FIXME: clear() is trying to do too many things. We should break it down into smaller functions.
void clear(ClearOptions);
+ // Sets a timer to notify the client that the initial empty document has
+ // been accessed, and thus it is no longer safe to show a provisional URL
+ // above the document without risking a URL spoof.
void didAccessInitialDocument();
- void didAccessInitialDocumentTimerFired(Timer<FrameLoader>*);
+
+ // If the initial empty document is showing and has been accessed, this
+ // cancels the timer and immediately notifies the client in cases that
+ // waiting to notify would allow a URL spoof.
+ void notifyIfInitialDocumentAccessed();
bool isLoading() const;
@@ -224,6 +231,7 @@ private:
void completed();
void checkTimerFired(Timer<FrameLoader>*);
+ void didAccessInitialDocumentTimerFired(Timer<FrameLoader>*);
void insertDummyHistoryItem();
« no previous file with comments | « no previous file | Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698