Don't wait to notify client of spoof attempt if a modal dialog is created.

Source/core/loader/FrameLoader.h

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) Research In Motion Limited 2009. All rights reserved.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
@@ skipping 93 matching lines @@
 
     // FIXME: These are all functions which stop loads. We have too many.
     // Warning: stopAllLoaders can and will detach the Frame out from under you. All callers need to either protect the Frame
     // or guarantee they won't in any way access the Frame after stopAllLoaders returns.
     void stopAllLoaders(ClearProvisionalItemPolicy = ShouldClearProvisionalItem);
     void stopLoading();
     bool closeURL();
     // FIXME: clear() is trying to do too many things. We should break it down into smaller functions.
     void clear(ClearOptions);
 
+    // Sets a timer to notify the client that the initial empty document has
+    // been accessed, and thus it is no longer safe to show a provisional URL
+    // above the document without risking a URL spoof.
     void didAccessInitialDocument();
     void didAccessInitialDocumentTimerFired(Timer<FrameLoader>*);

[darin (slow to review), 2013/09/03 23:21:45]

I wonder... should this second method really be public?

[Charlie Reis, 2013/09/04 00:01:10]

Nope.  Made it private.

+    // Cancels the timer and immediately notifies the client in cases that
+    // waiting to notify would allow a URL spoof.
+    void forceNotifyForInitialDocumentAccess();
 
     bool isLoading() const;
 
     int numPendingOrLoadingRequests(bool recurse) const;
     String outgoingReferrer() const;
     String outgoingOrigin() const;
 
     DocumentLoader* activeDocumentLoader() const;
     DocumentLoader* documentLoader() const { return m_documentLoader.get(); }
     DocumentLoader* policyDocumentLoader() const { return m_policyDocumentLoader.get(); }
@@ skipping 182 matching lines @@
     bool m_startingClientRedirect;
 
     SandboxFlags m_forcedSandboxFlags;
 
     RefPtr<HistoryItem> m_requestedHistoryItem;
 };
 
 } // namespace WebCore
 
 #endif // FrameLoader_h