Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2361983002:
GN: ANGLE (Closed)
DescriptionGN: ANGLE
Angle's existing GN files only work in Chrome, so I've written a new one.
This won't work on Windows, but our GN build doesn't work on Windows anyway. So this CL is an attempt to get a ahead of that curve on ANGLE. It looks large but fairly straightforward.
Now working on Linux:
$ gn gen angle --args=skia_use_angle=true
$ ninja -C angle
$ angle/dm --config angle-gl --src gm -w dm-out
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361983002
Committed: https://skia.googlesource.com/skia/+/d68f9b00389bf676b171f250e684486cb2fbd404
Patch Set 1 #Patch Set 2 : further #Patch Set 3 : bot #Patch Set 4 : rebase #Patch Set 5 : misc libs #Patch Set 6 : fix GN #
Messages
Total messages: 26 (18 generated)
Description was changed from ========== GN: ANGLE This won't work on Windows, but our GN build doesn't work on Windows anyway. This is an attempt to get a ahead of the curve on ANGLE. It looks complex. BUG=skia: ========== to ========== GN: ANGLE This won't work on Windows, but our GN build doesn't work on Windows anyway. This is an attempt to get a ahead of the curve on ANGLE. It looks complex. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361983002 ==========
Description was changed from ========== GN: ANGLE This won't work on Windows, but our GN build doesn't work on Windows anyway. This is an attempt to get a ahead of the curve on ANGLE. It looks complex. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361983002 ========== to ========== GN: ANGLE This won't work on Windows, but our GN build doesn't work on Windows anyway. This is an attempt to get a ahead of the curve on ANGLE. It looks complex. This is as far as I can go on Linux; I'm getting to the same error now with GN and GYP: ../src/gpu/gl/GrGLInterface.cpp:310 GrGLInterface::validate() failed. Could not validate ANGLE GL interface! WARNING: can not create GPU context for config 'angle-gl'. GM tests will be skipped. Skipping config angle-gl: Don't understand 'angle-gl'. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361983002 ==========
Description was changed from ========== GN: ANGLE This won't work on Windows, but our GN build doesn't work on Windows anyway. This is an attempt to get a ahead of the curve on ANGLE. It looks complex. This is as far as I can go on Linux; I'm getting to the same error now with GN and GYP: ../src/gpu/gl/GrGLInterface.cpp:310 GrGLInterface::validate() failed. Could not validate ANGLE GL interface! WARNING: can not create GPU context for config 'angle-gl'. GM tests will be skipped. Skipping config angle-gl: Don't understand 'angle-gl'. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361983002 ========== to ========== GN: ANGLE This won't work on Windows, but our GN build doesn't work on Windows anyway. This is an attempt to get a ahead of the curve on ANGLE. It looks complex. This may be as far as I can go on Linux; I'm getting to the same error now with GN and GYP: ../src/gpu/gl/GrGLInterface.cpp:310 GrGLInterface::validate() failed. Could not validate ANGLE GL interface! WARNING: can not create GPU context for config 'angle-gl'. GM tests will be skipped. Skipping config angle-gl: Don't understand 'angle-gl'. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361983002 ==========
Description was changed from ========== GN: ANGLE This won't work on Windows, but our GN build doesn't work on Windows anyway. This is an attempt to get a ahead of the curve on ANGLE. It looks complex. This may be as far as I can go on Linux; I'm getting to the same error now with GN and GYP: ../src/gpu/gl/GrGLInterface.cpp:310 GrGLInterface::validate() failed. Could not validate ANGLE GL interface! WARNING: can not create GPU context for config 'angle-gl'. GM tests will be skipped. Skipping config angle-gl: Don't understand 'angle-gl'. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361983002 ========== to ========== GN: ANGLE Angle's existing GN files only work in Chrome, so I've written a new one. This won't work on Windows, but our GN build doesn't work on Windows anyway. This is an attempt to get a ahead of the curve on ANGLE. It looks complex. This may be as far as I can go on Linux; I'm getting to the same error now with GN and GYP: ../src/gpu/gl/GrGLInterface.cpp:310 GrGLInterface::validate() failed. Could not validate ANGLE GL interface! WARNING: can not create GPU context for config 'angle-gl'. GM tests will be skipped. Skipping config angle-gl: Don't understand 'angle-gl'. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361983002 ==========
Description was changed from ========== GN: ANGLE Angle's existing GN files only work in Chrome, so I've written a new one. This won't work on Windows, but our GN build doesn't work on Windows anyway. This is an attempt to get a ahead of the curve on ANGLE. It looks complex. This may be as far as I can go on Linux; I'm getting to the same error now with GN and GYP: ../src/gpu/gl/GrGLInterface.cpp:310 GrGLInterface::validate() failed. Could not validate ANGLE GL interface! WARNING: can not create GPU context for config 'angle-gl'. GM tests will be skipped. Skipping config angle-gl: Don't understand 'angle-gl'. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361983002 ========== to ========== GN: ANGLE Angle's existing GN files only work in Chrome, so I've written a new one. This won't work on Windows, but our GN build doesn't work on Windows anyway. So this CL is an attempt to get a ahead of that curve on ANGLE. It looks large but fairly straightforward. This may be as far as I can go on Linux; I'm getting to the same error now with GN and GYP: ../src/gpu/gl/GrGLInterface.cpp:310 GrGLInterface::validate() failed. Could not validate ANGLE GL interface! WARNING: can not create GPU context for config 'angle-gl'. GM tests will be skipped. Skipping config angle-gl: Don't understand 'angle-gl'. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361983002 ==========
mtklein@chromium.org changed reviewers: + bsalomon@google.com
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/09/22 20:17:42, mtklein_C wrote: This seems ok but let take a shot at seeing whether I get the same failure with gyp on my linux box.
On 2016/09/23 13:29:11, bsalomon wrote: > On 2016/09/22 20:17:42, mtklein_C wrote: > > This seems ok but let take a shot at seeing whether I get the same failure with > gyp on my linux box. angle-gl config works for me in gyp, but it does not work from GN with this CL patched in.
On 2016/09/23 at 13:52:44, bsalomon wrote: > On 2016/09/23 13:29:11, bsalomon wrote: > > On 2016/09/22 20:17:42, mtklein_C wrote: > > > > This seems ok but let take a shot at seeing whether I get the same failure with > > gyp on my linux box. > > angle-gl config works for me in gyp, but it does not work from GN with this CL patched in. Ah! Indeed, GYP is now working for me too. I must have been confused. Will ping the thread when I get the GN version working.
Description was changed from ========== GN: ANGLE Angle's existing GN files only work in Chrome, so I've written a new one. This won't work on Windows, but our GN build doesn't work on Windows anyway. So this CL is an attempt to get a ahead of that curve on ANGLE. It looks large but fairly straightforward. This may be as far as I can go on Linux; I'm getting to the same error now with GN and GYP: ../src/gpu/gl/GrGLInterface.cpp:310 GrGLInterface::validate() failed. Could not validate ANGLE GL interface! WARNING: can not create GPU context for config 'angle-gl'. GM tests will be skipped. Skipping config angle-gl: Don't understand 'angle-gl'. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361983002 ========== to ========== GN: ANGLE Angle's existing GN files only work in Chrome, so I've written a new one. This won't work on Windows, but our GN build doesn't work on Windows anyway. So this CL is an attempt to get a ahead of that curve on ANGLE. It looks large but fairly straightforward. Now working on Linux: $ gn gen angle --args=skia_use_angle=true $ ninja -C angle $ angle/dm --config angle-gm --src gm -w dm-out BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361983002 ==========
Description was changed from ========== GN: ANGLE Angle's existing GN files only work in Chrome, so I've written a new one. This won't work on Windows, but our GN build doesn't work on Windows anyway. So this CL is an attempt to get a ahead of that curve on ANGLE. It looks large but fairly straightforward. Now working on Linux: $ gn gen angle --args=skia_use_angle=true $ ninja -C angle $ angle/dm --config angle-gm --src gm -w dm-out BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361983002 ========== to ========== GN: ANGLE Angle's existing GN files only work in Chrome, so I've written a new one. This won't work on Windows, but our GN build doesn't work on Windows anyway. So this CL is an attempt to get a ahead of that curve on ANGLE. It looks large but fairly straightforward. Now working on Linux: $ gn gen angle --args=skia_use_angle=true $ ninja -C angle $ angle/dm --config angle-gl --src gm -w dm-out BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361983002 ==========
I think we're good to go at PS 6.
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by mtklein@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== GN: ANGLE Angle's existing GN files only work in Chrome, so I've written a new one. This won't work on Windows, but our GN build doesn't work on Windows anyway. So this CL is an attempt to get a ahead of that curve on ANGLE. It looks large but fairly straightforward. Now working on Linux: $ gn gen angle --args=skia_use_angle=true $ ninja -C angle $ angle/dm --config angle-gl --src gm -w dm-out BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361983002 ========== to ========== GN: ANGLE Angle's existing GN files only work in Chrome, so I've written a new one. This won't work on Windows, but our GN build doesn't work on Windows anyway. So this CL is an attempt to get a ahead of that curve on ANGLE. It looks large but fairly straightforward. Now working on Linux: $ gn gen angle --args=skia_use_angle=true $ ninja -C angle $ angle/dm --config angle-gl --src gm -w dm-out BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361983002 Committed: https://skia.googlesource.com/skia/+/d68f9b00389bf676b171f250e684486cb2fbd404 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://skia.googlesource.com/skia/+/d68f9b00389bf676b171f250e684486cb2fbd404 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
