cros: Easy unlock UI broken because of submit button.

cros: Easy unlock UI broken because of submit button.

See screenshots. Fixed according to mocks.

Now: https://screenshot.googleplex.com/HUyRhT9Gee1
Previous: See bug.
Mocks: See bug.

BUG=646118
TEST=none

Committed: https://crrev.com/4f2d94c57f186e2eee1b01b80bf8fb8e7e61d037
Cr-Commit-Position: refs/heads/master@{#420759}

[sammiequon, 2016-09-23 00:55:32]

Description was changed from

==========
cros: Easy unlock UI broken because of submit button.

See screenshots. Fixed according to mocks.

BUG=646118
TEST=none
==========

to

==========
cros: Easy unlock UI broken because of submit button.

See screenshots. Fixed according to mocks.

Now: https://screenshot.googleplex.com/HUyRhT9Gee1
Previous: See bug.
Mocks: See bug.

BUG=646118
TEST=none
==========

[sammiequon, 2016-09-23 00:55:32]

sammiequon@chromium.org changed reviewers:
+ jdufault@chromium.org

[sammiequon, 2016-09-23 00:55:47]

On 2016/09/23 00:55:32, sammiequon wrote:
> mailto:sammiequon@chromium.org changed reviewers:
> + mailto:jdufault@chromium.org

jdufault@ - Please take a look. Thanks!

[jdufault, 2016-09-23 17:56:54]

lgtm. I think it'd be nice to also rename custom-icon to easy-unlock-icon, if
you decide to do it then please do so in a separate CL.

[sammiequon, 2016-09-23 21:16:23]

sammiequon@chromium.org changed reviewers:
+ xiyuan@chromium.org

[sammiequon, 2016-09-23 21:17:13]

On 2016/09/23 17:56:54, jdufault wrote:
> lgtm. I think it'd be nice to also rename custom-icon to easy-unlock-icon, if
> you decide to do it then please do so in a separate CL.

xiyuan@ - Please take a look. Thanks! Do you forsee any issues with renaming
custom-icon to easy-unlock-icon?

[xiyuan, 2016-09-23 21:32:01]

On 2016/09/23 21:17:13, sammiequon wrote:
> On 2016/09/23 17:56:54, jdufault wrote:
> > lgtm. I think it'd be nice to also rename custom-icon to easy-unlock-icon,
if
> > you decide to do it then please do so in a separate CL.
> 
> xiyuan@ - Please take a look. Thanks! Do you forsee any issues with renaming
> custom-icon to easy-unlock-icon?

The intention was to have an way to put an arbitrary icon on the user pod. Since
the icon is very specific to the smart lock feature and we don't have other
plans for it, I agree it makes sense to rename it to something more specific.
Use "smart-lock-icon" instead of "easy-unlock-icon" because smart lock is the
official name of the feature and easy unlock is the code before the official
name.

If we want to the renaming, think it is best to update relevant js/C++ code as
well to avoid future confusions (e.g. UserPodCustomIcon, showUserPodCustomIcon,
ShowUserPodCustomIcon etc). And since those are unrelated to this CL, we should
do it separately.

This CL lgtm.

[sammiequon, 2016-09-23 21:38:23]

The CQ bit was checked by sammiequon@chromium.org

[commit-bot: I haz the power, 2016-09-23 21:39:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 22:49:52]

Description was changed from

==========
cros: Easy unlock UI broken because of submit button.

See screenshots. Fixed according to mocks.

Now: https://screenshot.googleplex.com/HUyRhT9Gee1
Previous: See bug.
Mocks: See bug.

BUG=646118
TEST=none
==========

to

==========
cros: Easy unlock UI broken because of submit button.

See screenshots. Fixed according to mocks.

Now: https://screenshot.googleplex.com/HUyRhT9Gee1
Previous: See bug.
Mocks: See bug.

BUG=646118
TEST=none
==========

[commit-bot: I haz the power, 2016-09-23 22:49:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-23 22:53:00]

Description was changed from

==========
cros: Easy unlock UI broken because of submit button.

See screenshots. Fixed according to mocks.

Now: https://screenshot.googleplex.com/HUyRhT9Gee1
Previous: See bug.
Mocks: See bug.

BUG=646118
TEST=none
==========

to

==========
cros: Easy unlock UI broken because of submit button.

See screenshots. Fixed according to mocks.

Now: https://screenshot.googleplex.com/HUyRhT9Gee1
Previous: See bug.
Mocks: See bug.

BUG=646118
TEST=none

Committed: https://crrev.com/4f2d94c57f186e2eee1b01b80bf8fb8e7e61d037
Cr-Commit-Position: refs/heads/master@{#420759}
==========

[commit-bot: I haz the power, 2016-09-23 22:53:01]

Patchset 1 (id:??) landed as
https://crrev.com/4f2d94c57f186e2eee1b01b80bf8fb8e7e61d037
Cr-Commit-Position: refs/heads/master@{#420759}