Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: net/log/net_log_event_type_list.h

Issue 2361963002: Adding NetLog support to SafeBrowsingPingManager. (Closed)
Patch Set: Base64 encoding the payloads. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/log/net_log_event_type_list.h
diff --git a/net/log/net_log_event_type_list.h b/net/log/net_log_event_type_list.h
index f0d43fff931eb22fcdde38bf927e630020ef2bda..d5ebee6c6f30585f52796c5d60938e6e76396ef4 100644
--- a/net/log/net_log_event_type_list.h
+++ b/net/log/net_log_event_type_list.h
@@ -3020,6 +3020,23 @@ EVENT_TYPE(SAFE_BROWSING_CHECKING_URL)
// }
EVENT_TYPE(SAFE_BROWSING_DEFERRED)
+// The start/end of a Safe Browsing ping being sent.
+//
+// The BEGIN phase contains the following parameters:
+// {
+// "url": <The URL the ping is going to, which identifies the type of ping
+// that is being sent (eg: ThreatReport, SafeBrowsingHit)>
+// "data": <The base64 encoding of the payload sent with the ping>
+//
+// The END phase contains the following parameters:
+// {
+// "url": <The URL the ping is going to, which identifies the type of ping
+// that is being sent (eg: ThreatReport, SafeBrowsingHit)>
mmenke 2016/10/03 15:11:46 Is this completely redundant with the correspondin
lpz 2016/10/04 18:48:32 Yes, redundant. Removed.
+// "status": <The integer status of the report transmission. Corresponds to
+// URLRequestStatus::Status>
+// "error": <The error code returned by the server, 0 indicating success>
+EVENT_TYPE(SAFE_BROWSING_PING)
+
// Marks start of UploadDataStream that is logged on initialization.
// The END phase contains the following parameters:
// {

Powered by Google App Engine
This is Rietveld 408576698