Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4482)

Unified Diff: chrome/browser/safe_browsing/ping_manager.h

Issue 2361963002: Adding NetLog support to SafeBrowsingPingManager. (Closed)
Patch Set: Tidy up after final reviews. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/ping_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/ping_manager.h
diff --git a/chrome/browser/safe_browsing/ping_manager.h b/chrome/browser/safe_browsing/ping_manager.h
index 56d2d95241279670bc40f1811e4cbd6eb7c0c6e3..97f627c9be88c86cf907d9009ea88ea789e908d0 100644
--- a/chrome/browser/safe_browsing/ping_manager.h
+++ b/chrome/browser/safe_browsing/ping_manager.h
@@ -19,6 +19,7 @@
#include "components/safe_browsing_db/hit_report.h"
#include "components/safe_browsing_db/util.h"
#include "content/public/browser/permission_type.h"
+#include "net/log/net_log_with_source.h"
#include "net/url_request/url_fetcher_delegate.h"
#include "url/gurl.h"
@@ -69,9 +70,14 @@ class SafeBrowsingPingManager : public net::URLFetcherDelegate {
private:
friend class PermissionReporterBrowserTest;
+ friend class SafeBrowsingPingManagerTest;
FRIEND_TEST_ALL_PREFIXES(SafeBrowsingPingManagerTest,
TestSafeBrowsingHitUrl);
FRIEND_TEST_ALL_PREFIXES(SafeBrowsingPingManagerTest, TestThreatDetailsUrl);
+ FRIEND_TEST_ALL_PREFIXES(SafeBrowsingPingManagerTest,
+ TestReportThreatDetails);
+ FRIEND_TEST_ALL_PREFIXES(SafeBrowsingPingManagerTest,
+ TestReportSafeBrowsingHit);
typedef std::set<std::unique_ptr<net::URLFetcher>> Reports;
@@ -111,6 +117,8 @@ class SafeBrowsingPingManager : public net::URLFetcherDelegate {
// Sends reports of permission actions.
std::unique_ptr<PermissionReporter> permission_reporter_;
+ net::NetLogWithSource net_log_;
+
DISALLOW_COPY_AND_ASSIGN(SafeBrowsingPingManager);
};
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/ping_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698