Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2361953002: [tools] Improve callstats.html (Closed)

Created:
4 years, 3 months ago by Camillo Bruni
Modified:
4 years, 3 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Improve callstats.html callstats.html now directly tries to load a results.json file in the same directory when hosted over http. Additionally, avoiding innerHTML speeds up initial data creation. BUG=chromium:611010 NOTRY=true Committed: https://crrev.com/c0485c18a3b05437ea834e38f31c9cc053c70b4f Cr-Commit-Position: refs/heads/master@{#39645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -39 lines) Patch
M tools/callstats.html View 11 chunks +59 lines, -39 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Camillo Bruni
PTAL
4 years, 3 months ago (2016-09-22 18:56:24 UTC) #2
Michael Achenbach
lgtm
4 years, 3 months ago (2016-09-22 19:45:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361953002/1
4 years, 3 months ago (2016-09-22 20:55:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361953002/1
4 years, 3 months ago (2016-09-22 20:55:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 20:58:17 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 20:58:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0485c18a3b05437ea834e38f31c9cc053c70b4f
Cr-Commit-Position: refs/heads/master@{#39645}

Powered by Google App Engine
This is Rietveld 408576698