Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 2361943002: Add 2x icons resources to mash. (Closed)

Created:
4 years, 3 months ago by kylechar
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add 2x icons resources to mash. If device_scale_factor of 2 is used then ash crashes trying to load the 2x icons. Add the icon resources. BUG=none Committed: https://crrev.com/47085aa33f0ccc6ca39458371b5214c9fc251f9a Cr-Commit-Position: refs/heads/master@{#420490}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixes. #

Patch Set 3 : Use default arg. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -13 lines) Patch
M ash/mus/BUILD.gn View 4 chunks +20 lines, -2 lines 0 comments Download
M ash/mus/window_manager_application.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/mus/aura_init.h View 1 2 chunks +8 lines, -1 line 0 comments Download
M ui/views/mus/aura_init.cc View 1 4 chunks +12 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
kylechar
4 years, 3 months ago (2016-09-22 19:21:40 UTC) #3
sky
https://codereview.chromium.org/2361943002/diff/1/ui/views/mus/aura_init.h File ui/views/mus/aura_init.h (right): https://codereview.chromium.org/2361943002/diff/1/ui/views/mus/aura_init.h#newcode39 ui/views/mus/aura_init.h:39: AuraInit(shell::Connector* connector, How about making this the only constructor ...
4 years, 3 months ago (2016-09-22 20:31:43 UTC) #4
kylechar
https://codereview.chromium.org/2361943002/diff/1/ui/views/mus/aura_init.h File ui/views/mus/aura_init.h (right): https://codereview.chromium.org/2361943002/diff/1/ui/views/mus/aura_init.h#newcode39 ui/views/mus/aura_init.h:39: AuraInit(shell::Connector* connector, On 2016/09/22 20:31:42, sky wrote: > How ...
4 years, 3 months ago (2016-09-22 20:47:09 UTC) #5
sky
Indeed. I tend to favor a style guide that doesn't change on these sort of ...
4 years, 3 months ago (2016-09-22 21:31:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361943002/40001
4 years, 3 months ago (2016-09-22 21:54:25 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-22 23:01:04 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 23:04:05 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/47085aa33f0ccc6ca39458371b5214c9fc251f9a
Cr-Commit-Position: refs/heads/master@{#420490}

Powered by Google App Engine
This is Rietveld 408576698