Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: base/metrics/histogram_base.h

Issue 2361933002: Refactor histogram_macros.h. This improves documentation for the macros in the file, moves LOCAL_* … (Closed)
Patch Set: asvitkine Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/metrics/histogram_macros.h » ('j') | base/metrics/histogram_macros.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/histogram_base.h
diff --git a/base/metrics/histogram_base.h b/base/metrics/histogram_base.h
index d240099110e8bf66cf64d8a140cd860471880d5f..c699b68ba1bb7c2bbe518f3a80b759d53054dad3 100644
--- a/base/metrics/histogram_base.h
+++ b/base/metrics/histogram_base.h
@@ -92,7 +92,7 @@ class BASE_EXPORT HistogramBase {
static const Sample kSampleType_MAX; // INT_MAX
enum Flags {
- kNoFlags = 0,
+ kNoFlags = 0x0,
// Histogram should be UMA uploaded.
kUmaTargetedHistogramFlag = 0x1,
@@ -122,6 +122,8 @@ class BASE_EXPORT HistogramBase {
// histogram is created.
kIsPersistent = 0x40,
+ // TODO(rkaplow): Look into this, but looks like this is unused and can
+ // be removed.
// Only for Histogram and its sub classes: fancy bucket-naming support.
kHexRangePrintingFlag = 0x8000,
};
« no previous file with comments | « no previous file | base/metrics/histogram_macros.h » ('j') | base/metrics/histogram_macros.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698