Refactor histogram_macros.h. This improves documentation for the macros in the file, moves LOCAL_* …

base/metrics/histogram_base.h

Index: base/metrics/histogram_base.h
diff --git a/base/metrics/histogram_base.h b/base/metrics/histogram_base.h
index d240099110e8bf66cf64d8a140cd860471880d5f..c699b68ba1bb7c2bbe518f3a80b759d53054dad3 100644
--- a/base/metrics/histogram_base.h
+++ b/base/metrics/histogram_base.h
@@ -92,7 +92,7 @@ class BASE_EXPORT HistogramBase {
   static const Sample kSampleType_MAX;  // INT_MAX
 
   enum Flags {
-    kNoFlags = 0,
+    kNoFlags = 0x0,
 
     // Histogram should be UMA uploaded.
     kUmaTargetedHistogramFlag = 0x1,
@@ -122,6 +122,8 @@ class BASE_EXPORT HistogramBase {
     // histogram is created.
     kIsPersistent = 0x40,
 
+    // TODO(rkaplow): Look into this, but looks like this is unused and can

[Mark P, 2016/09/23 19:30:41]

Resolve before submitting.
(I see only 4 cases this flag is referred to.  You should be able to fix these
in this changelist or in an easy follow-up changelist.  The TODO should not end
up in the codebase.)

[rkaplow, 2016/09/26 20:16:09]

I think there's a bit of cleanup associated with this, so would rather do in a
subsequent CL. I don't mind removing the TODO if you'd like but I think it makes
sense to commit for now so it doesn't get forgotten (or, less easily)

[Mark P, 2016/09/26 23:06:47]

Okay.

+    // be removed.
     // Only for Histogram and its sub classes: fancy bucket-naming support.
     kHexRangePrintingFlag = 0x8000,
   };