Issue 236193014: Handlify AddDependentCode(), AddDependentCompilationInfo() and AddDependentIC().

Issue 236193014: Handlify AddDependentCode(), AddDependentCompilationInfo() and AddDependentIC(). (Closed)

Created:
6 years, 8 months ago by Benedikt Meurer

Modified:
6 years, 8 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handlify AddDependentCode(), AddDependentCompilationInfo() and AddDependentIC(). R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20756

Patch Set 2 : Didn't mean to modify AllocationSite::AddDependentCompilationInfo() #

Patch Set 4 : Address nit #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -40 lines)			Patch
M	src/hydrogen.h	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/hydrogen.cc	View	1 2 3	3 chunks	+9 lines, -8 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/hydrogen-instructions.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ic.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/lithium-codegen.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View	1 2	2 chunks	+10 lines, -8 lines	0 comments	Download
M	src/objects.cc	View	1 2	2 chunks	+25 lines, -17 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

lgtm with nits: https://codereview.chromium.org/236193014/diff/40001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/236193014/diff/40001/src/hydrogen.cc#newcode6833 src/hydrogen.cc:6833: handle(constant->map(), info->isolate()), Suggestion: below we are ...

6 years, 8 months ago (2014-04-15 08:58:35 UTC) #2

Benedikt Meurer

Committed patchset #4 manually as r20756 (presubmit successful).

6 years, 8 months ago (2014-04-15 10:15:00 UTC) #3

Benedikt Meurer

6 years, 8 months ago (2014-04-15 10:15:02 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/236193014/diff/40001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/236193014/diff/40001/src/hydrogen.cc#newcode6833
src/hydrogen.cc:6833: handle(constant->map(), info->isolate()),
On 2014/04/15 08:58:35, Igor Sheludko wrote:
> Suggestion: below we are also wrapping the map to a handle. What if we do that
> only once?

Done.

Expand Messages | Collapse Messages