Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issue 236193011: Add /recent (Closed)

Created:
6 years, 8 months ago by jcgregorio
Modified:
6 years, 8 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@all
Visibility:
Public.

Description

Add /recent, a page that displays the last 20 tries. Also broke out CSS as a separate file and added a title bar across both pages to easily navigate between Home and Recent. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14190

Patch Set 1 #

Patch Set 2 : stray print #

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -25 lines) Patch
A experimental/webtry/css/webtry.css View 1 1 chunk +60 lines, -0 lines 0 comments Download
M experimental/webtry/templates/index.html View 2 chunks +8 lines, -17 lines 0 comments Download
A experimental/webtry/templates/recent.html View 1 chunk +26 lines, -0 lines 3 comments Download
M experimental/webtry/webtry.go View 1 6 chunks +76 lines, -8 lines 6 comments Download

Messages

Total messages: 8 (0 generated)
jcgregorio
6 years, 8 months ago (2014-04-14 18:13:27 UTC) #1
mtklein
LGTM https://codereview.chromium.org/236193011/diff/20001/experimental/webtry/templates/recent.html File experimental/webtry/templates/recent.html (right): https://codereview.chromium.org/236193011/diff/20001/experimental/webtry/templates/recent.html#newcode18 experimental/webtry/templates/recent.html:18: <h2><a href="/c/{{.Hash}}">{{.CreateTS}}</a></h2> We might want to add the ...
6 years, 8 months ago (2014-04-14 18:27:53 UTC) #2
jcgregorio
https://codereview.chromium.org/236193011/diff/20001/experimental/webtry/templates/recent.html File experimental/webtry/templates/recent.html (right): https://codereview.chromium.org/236193011/diff/20001/experimental/webtry/templates/recent.html#newcode18 experimental/webtry/templates/recent.html:18: <h2><a href="/c/{{.Hash}}">{{.CreateTS}}</a></h2> Possibly. We might also want to add ...
6 years, 8 months ago (2014-04-14 18:43:45 UTC) #3
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 8 months ago (2014-04-14 18:54:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/236193011/20001
6 years, 8 months ago (2014-04-14 18:54:38 UTC) #5
mtklein
https://codereview.chromium.org/236193011/diff/20001/experimental/webtry/templates/recent.html File experimental/webtry/templates/recent.html (right): https://codereview.chromium.org/236193011/diff/20001/experimental/webtry/templates/recent.html#newcode18 experimental/webtry/templates/recent.html:18: <h2><a href="/c/{{.Hash}}">{{.CreateTS}}</a></h2> On 2014/04/14 18:43:46, jcgregorio wrote: > Possibly. ...
6 years, 8 months ago (2014-04-14 19:27:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/236193011/20001
6 years, 8 months ago (2014-04-14 19:27:55 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 20:12:14 UTC) #8
Message was sent while issue was closed.
Change committed as 14190

Powered by Google App Engine
This is Rietveld 408576698