Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: Source/core/rendering/compositing/RenderLayerCompositor.cpp

Issue 236193002: Early return in RenderLayerCompositor::updateForceCompositingMode. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 destroyRootLayer(); 143 destroyRootLayer();
144 144
145 notifyIFramesOfCompositingChange(); 145 notifyIFramesOfCompositingChange();
146 } 146 }
147 147
148 void RenderLayerCompositor::updateForceCompositingMode() 148 void RenderLayerCompositor::updateForceCompositingMode()
149 { 149 {
150 // FIXME: Can settings really be null here? 150 // FIXME: Can settings really be null here?
151 if (Settings* settings = m_renderView.document().settings()) { 151 if (Settings* settings = m_renderView.document().settings()) {
152 bool forceCompositingMode = settings->forceCompositingMode() && m_hasAcc eleratedCompositing; 152 bool forceCompositingMode = settings->forceCompositingMode() && m_hasAcc eleratedCompositing;
153 if (forceCompositingMode && !isMainFrame()) 153 if (forceCompositingMode && !isMainFrame()) {
154 // requiresCompositingForScrollableFrame will return a stale value i f the RenderView
155 // needsLayout. Skip updating m_forceCompositingMode here as we'll c all back into
156 // this method at the end of layout.
157 if (m_renderView.needsLayout())
158 return;
154 forceCompositingMode = m_compositingReasonFinder.requiresCompositing ForScrollableFrame(); 159 forceCompositingMode = m_compositingReasonFinder.requiresCompositing ForScrollableFrame();
160 }
155 if (forceCompositingMode != m_forceCompositingMode) { 161 if (forceCompositingMode != m_forceCompositingMode) {
156 setCompositingLayersNeedRebuild(); 162 setCompositingLayersNeedRebuild();
157 m_forceCompositingMode = forceCompositingMode; 163 m_forceCompositingMode = forceCompositingMode;
158 } 164 }
159 } 165 }
160 } 166 }
161 167
162 void RenderLayerCompositor::updateAcceleratedCompositingSettings() 168 void RenderLayerCompositor::updateAcceleratedCompositingSettings()
163 { 169 {
164 bool hasAcceleratedCompositing = false; 170 bool hasAcceleratedCompositing = false;
(...skipping 1545 matching lines...) Expand 10 before | Expand all | Expand 10 after
1710 } else if (graphicsLayer == m_scrollLayer.get()) { 1716 } else if (graphicsLayer == m_scrollLayer.get()) {
1711 name = "LocalFrame Scrolling Layer"; 1717 name = "LocalFrame Scrolling Layer";
1712 } else { 1718 } else {
1713 ASSERT_NOT_REACHED(); 1719 ASSERT_NOT_REACHED();
1714 } 1720 }
1715 1721
1716 return name; 1722 return name;
1717 } 1723 }
1718 1724
1719 } // namespace WebCore 1725 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698