Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2361913002: Add custom filter to bot-list and task-list (Closed)

Created:
4 years, 3 months ago by kjlubick
Modified:
4 years, 3 months ago
Reviewers:
KevinL, jcgregorio, stephana
CC:
borenet, chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Base URL:
git@github.com:luci/luci-py@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Add custom filter to bot-list and task-list Also fix bot-page (and others) links to tasks BUG=631047 Committed: https://github.com/luci/luci-py/commit/a97d86a111c2683bd456adb8f53ce30bf2cfb339

Patch Set 1 #

Patch Set 2 : Rebuild #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -13 lines) Patch
M appengine/swarming/elements/build/elements.html View 1 2 chunks +4 lines, -4 lines 0 comments Download
M appengine/swarming/elements/res/imp/botlist/bot-filters.html View 3 chunks +12 lines, -3 lines 0 comments Download
M appengine/swarming/elements/res/imp/botlist/bot-list.html View 2 chunks +2 lines, -0 lines 0 comments Download
M appengine/swarming/elements/res/imp/common/common-behavior.html View 1 chunk +11 lines, -3 lines 0 comments Download
M appengine/swarming/elements/res/imp/common/query-column-filter-behavior.html View 1 chunk +15 lines, -0 lines 0 comments Download
M appengine/swarming/elements/res/imp/tasklist/task-filters.html View 2 chunks +6 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
kjlubick
https://screenshot.googleplex.com/8UExSmeoYvH
4 years, 3 months ago (2016-09-22 17:50:29 UTC) #2
kjlubick
Demo live at https://2358-826be63-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com
4 years, 3 months ago (2016-09-22 17:52:27 UTC) #3
kjlubick
On 2016/09/22 at 17:52:27, kjlubick wrote: > Demo live at https://2358-826be63-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com https://2358-826be63-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/newui/tasklist and https://2358-826be63-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/newui/botlist to ...
4 years, 3 months ago (2016-09-22 17:53:05 UTC) #4
jcgregorio
lgtm
4 years, 3 months ago (2016-09-22 18:01:09 UTC) #5
stephana
On 2016/09/22 18:01:09, jcgregorio wrote: > lgtm lgtm
4 years, 3 months ago (2016-09-22 18:06:23 UTC) #6
KevinL
lgtm
4 years, 3 months ago (2016-09-22 18:10:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361913002/20001
4 years, 3 months ago (2016-09-22 18:10:13 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 18:14:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/a97d86a111c2683bd456adb8f53ce30bf2cfb339

Powered by Google App Engine
This is Rietveld 408576698