Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23619089: [Android WebView] Populate WebKit WebPreferences correctly in browser (Closed)

Created:
7 years, 3 months ago by benm (inactive)
Modified:
7 years, 2 months ago
Reviewers:
joth
CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, jam, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Currently Android WebView will push settings from the java side to the renderer, but if the browser needs to read those settings back we will use a default set from WebContentsImpl as we neglect to override ContentBrowserClient::OverrideWebKitPrefs. This means that the browser and renderer can see out of sync preference values. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225611

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : fix clang #

Total comments: 1

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -87 lines) Patch
M android_webview/android_webview.gyp View 1 1 chunk +4 lines, -2 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 3 chunks +14 lines, -0 lines 0 comments Download
A android_webview/browser/aw_web_preferences_populater.h View 1 1 chunk +27 lines, -0 lines 0 comments Download
A + android_webview/browser/aw_web_preferences_populater.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/browser/jni_dependency_factory.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M android_webview/native/aw_settings.h View 2 chunks +6 lines, -0 lines 0 comments Download
M android_webview/native/aw_settings.cc View 1 2 3 4 chunks +127 lines, -83 lines 0 comments Download
A android_webview/native/aw_web_preferences_populater_impl.h View 1 2 3 4 1 chunk +34 lines, -0 lines 0 comments Download
A android_webview/native/aw_web_preferences_populater_impl.cc View 1 2 3 4 5 1 chunk +26 lines, -0 lines 0 comments Download
M android_webview/native/webview_native.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
joth
https://codereview.chromium.org/23619089/diff/1/android_webview/native/aw_settings.cc File android_webview/native/aw_settings.cc (right): https://codereview.chromium.org/23619089/diff/1/android_webview/native/aw_settings.cc#newcode56 android_webview/native/aw_settings.cc:56: AwSettings::~AwSettings() { if (web_contents()) web_contents()->SetUserData(kKey, NULL);
7 years, 2 months ago (2013-09-25 12:04:00 UTC) #1
benm (inactive)
https://codereview.chromium.org/23619089/diff/1/android_webview/native/aw_settings.cc File android_webview/native/aw_settings.cc (right): https://codereview.chromium.org/23619089/diff/1/android_webview/native/aw_settings.cc#newcode56 android_webview/native/aw_settings.cc:56: AwSettings::~AwSettings() { On 2013/09/25 12:04:01, joth wrote: > if ...
7 years, 2 months ago (2013-09-25 16:00:55 UTC) #2
benm (inactive)
ptal
7 years, 2 months ago (2013-09-25 19:23:58 UTC) #3
joth
lgtm https://codereview.chromium.org/23619089/diff/17001/android_webview/native/aw_web_preferences_populater_impl.cc File android_webview/native/aw_web_preferences_populater_impl.cc (right): https://codereview.chromium.org/23619089/diff/17001/android_webview/native/aw_web_preferences_populater_impl.cc#newcode20 android_webview/native/aw_web_preferences_populater_impl.cc:20: AwSettings::FromWebContents(web_contents)->PopulateWebPreferences(web_prefs); early out if null (popup case it ...
7 years, 2 months ago (2013-09-26 10:44:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/23619089/26001
7 years, 2 months ago (2013-09-26 11:18:11 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=81663
7 years, 2 months ago (2013-09-26 15:38:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/23619089/26001
7 years, 2 months ago (2013-09-26 16:10:26 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=81786
7 years, 2 months ago (2013-09-26 19:56:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/23619089/26001
7 years, 2 months ago (2013-09-26 22:01:05 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-09-27 00:18:17 UTC) #10
Message was sent while issue was closed. 
Change committed as 225611

Powered by Google App Engine
This is Rietveld 408576698