cc: Clean up PBRWP::ScheduleTasks a bit.

cc/resources/pixel_buffer_raster_worker_pool.cc

Index: cc/resources/pixel_buffer_raster_worker_pool.cc
diff --git a/cc/resources/pixel_buffer_raster_worker_pool.cc b/cc/resources/pixel_buffer_raster_worker_pool.cc
index 48e6f9a114b58e34743c5396e66b16b91602a081..f2990b2eaef1c5109934efe61f8fa644e744e3cf 100644
--- a/cc/resources/pixel_buffer_raster_worker_pool.cc
+++ b/cc/resources/pixel_buffer_raster_worker_pool.cc
@@ -148,6 +148,8 @@ void PixelBufferRasterWorkerPool::ScheduleTasks(RasterTask::Queue* queue) {
   should_notify_client_if_no_tasks_are_pending_ = true;
   should_notify_client_if_no_tasks_required_for_activation_are_pending_ = true;
 
+  tasks_required_for_activation_.clear();
+
   // Build new pixel buffer task set.
   TaskMap new_pixel_buffer_tasks;
   for (RasterTaskVector::const_iterator it = raster_tasks().begin();
@@ -156,15 +158,11 @@ void PixelBufferRasterWorkerPool::ScheduleTasks(RasterTask::Queue* queue) {
     DCHECK(new_pixel_buffer_tasks.find(task) == new_pixel_buffer_tasks.end());
     DCHECK(!task->HasCompleted());
 
-    // Use existing pixel buffer task if available.
-    TaskMap::iterator pixel_buffer_it = pixel_buffer_tasks_.find(task);
-    if (pixel_buffer_it == pixel_buffer_tasks_.end()) {
-      new_pixel_buffer_tasks[task] = NULL;
-      continue;
-    }
-
-    new_pixel_buffer_tasks[task] = pixel_buffer_it->second;
+    new_pixel_buffer_tasks[task] = pixel_buffer_tasks_[task];
     pixel_buffer_tasks_.erase(task);
+
+    if (IsRasterTaskRequiredForActivation(task))
+      tasks_required_for_activation_.insert(task);
   }
 
   // Transfer remaining pixel buffer tasks to |new_pixel_buffer_tasks|
@@ -184,23 +182,19 @@ void PixelBufferRasterWorkerPool::ScheduleTasks(RasterTask::Queue* queue) {
                        completed_tasks_.end(),
                        task) == completed_tasks_.end());
       completed_tasks_.push_back(task);
-    }
-  }
-
-  tasks_required_for_activation_.clear();
-  for (TaskMap::iterator it = new_pixel_buffer_tasks.begin();
-       it != new_pixel_buffer_tasks.end(); ++it) {
-    internal::RasterWorkerPoolTask* task = it->first;
-    if (IsRasterTaskRequiredForActivation(task))
+    } else if (IsRasterTaskRequiredForActivation(task)) {
       tasks_required_for_activation_.insert(task);
+    }
   }
 
-  // |tasks_required_for_activation_| contains all tasks that need to
-  // complete before we can send a "ready to activate" signal. Tasks
-  // that have already completed should not be part of this set.
-  for (TaskDeque::const_iterator it = completed_tasks_.begin();
-       it != completed_tasks_.end(); ++it) {
-    tasks_required_for_activation_.erase(*it);
+  if (!tasks_required_for_activation_.empty()) {

[reveman, 2013/09/13 16:51:46]

this is just an optimization, right? can you instead break out of the loop below
as soon as |tasks_required_for_activation_| is empty?

[vmpstr, 2013/09/16 16:09:16]

Done. I did an explicit if/break, but it could also be a part of the for loop
condition. Let me know if you prefer that instead.

+    // |tasks_required_for_activation_| contains all tasks that need to
+    // complete before we can send a "ready to activate" signal. Tasks
+    // that have already completed should not be part of this set.
+    for (TaskDeque::const_iterator it = completed_tasks_.begin();
+         it != completed_tasks_.end(); ++it) {
+      tasks_required_for_activation_.erase(*it);
+    }
   }
 
   pixel_buffer_tasks_.swap(new_pixel_buffer_tasks);