cc: Clean up PBRWP::ScheduleTasks a bit.

cc: Clean up PBRWP::ScheduleTasks a bit.

This patch is a small clean-up to the schedule tasks.

BUG=none
R=reveman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223420

[vmpstr, 2013-09-12 22:40:24]

Please take a look.

[reveman, 2013-09-13 16:51:46]

https://codereview.chromium.org/23619048/diff/1/cc/resources/pixel_buffer_ras...
File cc/resources/pixel_buffer_raster_worker_pool.cc (right):

https://codereview.chromium.org/23619048/diff/1/cc/resources/pixel_buffer_ras...
cc/resources/pixel_buffer_raster_worker_pool.cc:190: if
(!tasks_required_for_activation_.empty()) {
this is just an optimization, right? can you instead break out of the loop below
as soon as |tasks_required_for_activation_| is empty?

[vmpstr, 2013-09-16 16:09:16]

https://codereview.chromium.org/23619048/diff/1/cc/resources/pixel_buffer_ras...
File cc/resources/pixel_buffer_raster_worker_pool.cc (right):

https://codereview.chromium.org/23619048/diff/1/cc/resources/pixel_buffer_ras...
cc/resources/pixel_buffer_raster_worker_pool.cc:190: if
(!tasks_required_for_activation_.empty()) {
On 2013/09/13 16:51:46, David Reveman wrote:
> this is just an optimization, right? can you instead break out of the loop
below
> as soon as |tasks_required_for_activation_| is empty?

Done. I did an explicit if/break, but it could also be a part of the for loop
condition. Let me know if you prefer that instead.

[vmpstr, 2013-09-16 16:09:25]

PTAL.

[reveman, 2013-09-16 16:31:56]

On 2013/09/16 16:09:16, vmpstr wrote:
>
https://codereview.chromium.org/23619048/diff/1/cc/resources/pixel_buffer_ras...
> File cc/resources/pixel_buffer_raster_worker_pool.cc (right):
> 
>
https://codereview.chromium.org/23619048/diff/1/cc/resources/pixel_buffer_ras...
> cc/resources/pixel_buffer_raster_worker_pool.cc:190: if
> (!tasks_required_for_activation_.empty()) {
> On 2013/09/13 16:51:46, David Reveman wrote:
> > this is just an optimization, right? can you instead break out of the loop
> below
> > as soon as |tasks_required_for_activation_| is empty?
> 
> Done. I did an explicit if/break, but it could also be a part of the for loop
> condition. Let me know if you prefer that instead.

Yes, part of the for loop statement sounds good.

[reveman, 2013-09-16 16:32:36]

lgtm after moving empty() check to for loop statement

[commit-bot: I haz the power, 2013-09-16 18:22:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vmpstr@chromium.org/23619048/11001

[commit-bot: I haz the power, 2013-09-16 21:33:35]

Change committed as 223420