Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 23619036: Reland "Clean up after r16292 (disable optimization for StringWrappers)." (Closed)

Created:
7 years, 3 months ago by Yang
Modified:
7 years, 3 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Reland "Clean up after r16292 (disable optimization for StringWrappers)." BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16691

Patch Set 1 #

Patch Set 2 : fix bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -95 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +1 line, -19 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 4 chunks +12 lines, -6 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +1 line, -15 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 4 chunks +10 lines, -5 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +1 line, -16 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 4 chunks +12 lines, -6 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +1 line, -15 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 5 chunks +16 lines, -13 lines 0 comments Download
M test/mjsunit/regress/regress-2855.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
Please take a look. This first patch set r16677. The bug in there is fixed ...
7 years, 3 months ago (2013-09-12 15:13:14 UTC) #1
ulan
lgtm
7 years, 3 months ago (2013-09-12 15:25:45 UTC) #2
Yang
7 years, 3 months ago (2013-09-12 16:19:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16691 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698