Source/bindings/v8/ScriptFunctionCall.cpp - Issue 23619034: Pass isolate to v8::False() / v8::True() when possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptFunctionCall.cpp

Issue 23619034: Pass isolate to v8::False() / v8::True() when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update more places Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScriptFunctionCall.cpp

diff --git a/Source/bindings/v8/ScriptFunctionCall.cpp b/Source/bindings/v8/ScriptFunctionCall.cpp

index 9bfd27902dd97c7255501c08cb9192aa63aebdc6..69a6e0e7c232a1c8f07ee1972bbf444277cb3a4c 100644

--- a/Source/bindings/v8/ScriptFunctionCall.cpp

+++ b/Source/bindings/v8/ScriptFunctionCall.cpp

@@ -103,7 +103,7 @@ void ScriptCallArgumentHandler::appendArgument(int argument)

void ScriptCallArgumentHandler::appendArgument(bool argument)

{

- m_arguments.append(v8Boolean(argument));

+ m_arguments.append(v8Boolean(argument, m_scriptState->isolate()));

}

ScriptFunctionCall::ScriptFunctionCall(const ScriptObject& thisObject, const String& name)