Issue 2361903003: aw: Fix FBO restore bug

Issue 2361903003: aw: Fix FBO restore bug (Closed)

Created:
4 years, 3 months ago by boliu

Modified:
4 years, 3 months ago

Reviewers:
danakj, Tobias Sargeant

CC:
chromium-reviews, android-webview-reviews_chromium.org

Target Ref:
refs/pending/branch-heads/2785_124

Project:
chromium

Visibility:
Public.

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -12 lines)			Patch
M	android_webview/browser/hardware_renderer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	android_webview/browser/hardware_renderer.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	android_webview/browser/render_thread_manager.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	android_webview/browser/surfaces_instance.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	android_webview/browser/surfaces_instance.cc	View	1 chunk	+8 lines, -4 lines	0 comments	Download

Total messages: 7 (2 generated)

boliu

instead of a big comment explaining why A has to happen before B and don't ...

4 years, 3 months ago (2016-09-22 21:22:33 UTC) #2

boliu

Committed patchset #1 (id:1) manually as 8cc537a6c871c18e636cba0c10ac0ee61b7ccf06.

4 years, 3 months ago (2016-09-22 21:29:34 UTC) #4

boliu

On 2016/09/22 21:29:34, boliu wrote: > Committed patchset #1 (id:1) manually as > 8cc537a6c871c18e636cba0c10ac0ee61b7ccf06. kerz ...

4 years, 3 months ago (2016-09-22 21:30:56 UTC) #5

Tobias Sargeant

4 years, 3 months ago (2016-09-22 21:55:09 UTC) #7

Message was sent while issue was closed.

On 2016/09/22 21:41:47, danakj wrote:
> LGTM

LGTM also, based on OOB conversation.