Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/base/escape_unittest.cc

Issue 23619016: Switch the offset conversion routines from... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/autocomplete/search_provider_unittest.cc ('K') | « chrome/browser/autocomplete/search_provider_unittest.cc ('k') | net/base/net_util.cc » ('j') | net/base/net_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/escape_unittest.cc
===================================================================
--- net/base/escape_unittest.cc (revision 221015)
+++ net/base/escape_unittest.cc (working copy)
@@ -337,10 +337,11 @@
TEST(EscapeTest, AdjustOffset) {
const AdjustOffsetCase adjust_cases[] = {
- {"", 0, std::string::npos},
+ {"", 0, 0},
msw 2013/09/06 00:31:08 nit: also test {"", 1, std::string::npos}
Peter Kasting 2013/09/06 19:04:36 Done.
{"test", 0, 0},
{"test", 2, 2},
- {"test", 4, std::string::npos},
+ {"test", 4, 4},
+ {"test", 5, std::string::npos},
{"test", std::string::npos, std::string::npos},
{"%2dtest", 6, 4},
{"%2dtest", 2, std::string::npos},
« chrome/browser/autocomplete/search_provider_unittest.cc ('K') | « chrome/browser/autocomplete/search_provider_unittest.cc ('k') | net/base/net_util.cc » ('j') | net/base/net_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698