components/offline_pages/background/request_coordinator_event_logger.cc - Issue 2361883002: [Offline Pages] Adds classification of some prerender FinalStatus codes as canceled operations or a…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_coordinator_event_logger.cc

Issue 2361883002: [Offline Pages] Adds classification of some prerender FinalStatus codes as canceled operations or a… (Closed)

Patch Set: Reworked per feedback Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/background/request_coordinator.cc ('k') | components/offline_pages/background/request_coordinator_unittest.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/request_coordinator_event_logger.cc

diff --git a/components/offline_pages/background/request_coordinator_event_logger.cc b/components/offline_pages/background/request_coordinator_event_logger.cc

index 7bafc0504a6796f3bd8a6ddc435e384bd9dc1bf4..a4934ae2c2903c7c70cf6e1c72453ce57a22f9bf 100644

--- a/components/offline_pages/background/request_coordinator_event_logger.cc

+++ b/components/offline_pages/background/request_coordinator_event_logger.cc

@@ -29,6 +29,8 @@ static std::string OfflinerRequestStatusToString(

return "FOREGROUND_CANCELED";

case Offliner::REQUEST_COORDINATOR_TIMED_OUT:

return "REQUEST_COORDINATOR_TIMED_OUT";

+ case Offliner::PRERENDERING_FAILED_NO_RETRY:

+ return "PRERENDERING_FAILED_NO_RETRY";

default:

NOTREACHED();

return std::to_string(static_cast<int>(request_status));