[Offline Pages] Adds classification of some prerender FinalStatus codes as canceled operations or a…

chrome/browser/android/offline_pages/prerendering_loader_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/prerendering_loader.h"
 
 #include "base/bind.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/run_loop.h"
@@ skipping 10 matching lines @@
 // Adapter that intercepts prerender stack calls for testing.
 class TestAdapter : public PrerenderAdapter {
  public:
   explicit TestAdapter(PrerenderAdapter::Observer* observer)
       : PrerenderAdapter(observer),
         active_(false),
         disabled_(false),
         fail_start_(false),
         observer_(observer),
         web_contents_(nullptr),
-        final_status_(prerender::FinalStatus::FINAL_STATUS_MAX) {}
+        final_status_(prerender::FINAL_STATUS_MAX) {}
   ~TestAdapter() override {}
 
   // PrerenderAdapter implementation.
   bool CanPrerender() const override;
   bool StartPrerender(
       content::BrowserContext* browser_context,
       const GURL& url,
       content::SessionStorageNamespace* session_storage_namespace,
       const gfx::Size& size) override;
   content::WebContents* GetWebContents() const override;
@@ skipping 136 matching lines @@
 
 TEST_F(PrerenderingLoaderTest, StopLoadingWhenIdle) {
   EXPECT_TRUE(loader()->IsIdle());
   loader()->StopLoading();
   EXPECT_TRUE(loader()->IsIdle());
 }
 
 TEST_F(PrerenderingLoaderTest, LoadPageLoadSucceededFromDomContentLoaded) {
   test_adapter()->Configure(
       content::WebContentsTester::CreateTestWebContents(profile(), NULL),
-      prerender::FinalStatus::FINAL_STATUS_USED);
+      prerender::FINAL_STATUS_USED);
   GURL gurl("http://testit.sea");
   EXPECT_TRUE(loader()->IsIdle());
   EXPECT_FALSE(loader()->IsLoaded());
   EXPECT_TRUE(loader()->LoadPage(
       gurl,
       base::Bind(&PrerenderingLoaderTest::OnLoadDone, base::Unretained(this))));
 
   test_adapter()->GetObserver()->OnPrerenderDomContentLoaded();
   // Skip SnapshotController's wait time and emulate StartSnapshot call.
   loader()->StartSnapshot();
   PumpLoop();
   EXPECT_FALSE(loader()->IsIdle());
   EXPECT_TRUE(loader()->IsLoaded());
   EXPECT_TRUE(callback_called());
   EXPECT_EQ(Offliner::RequestStatus::LOADED, callback_load_status());
 
   loader()->StopLoading();
   EXPECT_TRUE(loader()->IsIdle());
   EXPECT_FALSE(loader()->IsLoaded());
 }
 
 TEST_F(PrerenderingLoaderTest, LoadPageLoadSucceededFromPrerenderStopLoading) {
   test_adapter()->Configure(
       content::WebContentsTester::CreateTestWebContents(profile(), NULL),
-      prerender::FinalStatus::FINAL_STATUS_USED);
+      prerender::FINAL_STATUS_USED);
   GURL gurl("http://testit.sea");
   EXPECT_TRUE(loader()->IsIdle());
   EXPECT_FALSE(loader()->IsLoaded());
   EXPECT_TRUE(loader()->LoadPage(
       gurl,
       base::Bind(&PrerenderingLoaderTest::OnLoadDone, base::Unretained(this))));
 
   PumpLoop();
   EXPECT_FALSE(loader()->IsIdle());
   EXPECT_FALSE(loader()->IsLoaded());
 
   test_adapter()->GetObserver()->OnPrerenderStopLoading();
   PumpLoop();
   EXPECT_FALSE(loader()->IsIdle());
   EXPECT_TRUE(loader()->IsLoaded());
   EXPECT_TRUE(callback_called());
   EXPECT_EQ(Offliner::RequestStatus::LOADED, callback_load_status());
 
   // Consider Prerenderer stops (eg, times out) before Loader is done with it.
   test_adapter()->GetObserver()->OnPrerenderStop();
   PumpLoop();
   EXPECT_TRUE(loader()->IsIdle());
   EXPECT_FALSE(loader()->IsLoaded());
   EXPECT_EQ(Offliner::RequestStatus::PRERENDERING_CANCELED,
             callback_load_status());
 }
 
 TEST_F(PrerenderingLoaderTest, LoadPageLoadFailedNoContent) {
-  test_adapter()->Configure(
-      nullptr /* web_contents */,
-      prerender::FinalStatus::FINAL_STATUS_MEMORY_LIMIT_EXCEEDED);
+  test_adapter()->Configure(nullptr /* web_contents */,
+                            prerender::FINAL_STATUS_MEMORY_LIMIT_EXCEEDED);
   GURL gurl("http://testit.sea");
   EXPECT_TRUE(loader()->IsIdle());
   EXPECT_TRUE(loader()->LoadPage(
       gurl,
       base::Bind(&PrerenderingLoaderTest::OnLoadDone, base::Unretained(this))));
   EXPECT_FALSE(loader()->IsIdle());
   EXPECT_FALSE(loader()->IsLoaded());
 
   test_adapter()->GetObserver()->OnPrerenderDomContentLoaded();
   PumpLoop();
   EXPECT_TRUE(loader()->IsIdle());
   EXPECT_TRUE(callback_called());
   // We did not provide any WebContents for the callback so expect did not load.
   EXPECT_EQ(Offliner::RequestStatus::PRERENDERING_FAILED,
             callback_load_status());
 
   // Stopped event causes no harm.
   test_adapter()->GetObserver()->OnPrerenderStop();
   PumpLoop();
 }
 
+TEST_F(PrerenderingLoaderTest, LoadPageLoadFailedNoRetry) {
+  test_adapter()->Configure(nullptr /* web_contents */,
+                            prerender::FINAL_STATUS_SAFE_BROWSING);
+  GURL gurl("http://testit.sea");
+  EXPECT_TRUE(loader()->IsIdle());
+  EXPECT_TRUE(loader()->LoadPage(
+      gurl,
+      base::Bind(&PrerenderingLoaderTest::OnLoadDone, base::Unretained(this))));
+  EXPECT_FALSE(loader()->IsIdle());
+  EXPECT_FALSE(loader()->IsLoaded());
+
+  test_adapter()->GetObserver()->OnPrerenderDomContentLoaded();
+  PumpLoop();
+  EXPECT_TRUE(loader()->IsIdle());
+  EXPECT_TRUE(callback_called());
+  // We did not provide any WebContents for the callback so expect did not load.
+  // FinalStatus is non-retryable failure.
+  EXPECT_EQ(Offliner::RequestStatus::PRERENDERING_FAILED_NO_RETRY,
+            callback_load_status());
+
+  // Stopped event causes no harm.
+  test_adapter()->GetObserver()->OnPrerenderStop();
+  PumpLoop();
+}
+
+TEST_F(PrerenderingLoaderTest, LoadPageLoadCanceled) {
+  test_adapter()->Configure(nullptr /* web_contents */,
+                            prerender::FINAL_STATUS_CANCELLED);
+  GURL gurl("http://testit.sea");
+  EXPECT_TRUE(loader()->IsIdle());
+  EXPECT_TRUE(loader()->LoadPage(
+      gurl,
+      base::Bind(&PrerenderingLoaderTest::OnLoadDone, base::Unretained(this))));
+  EXPECT_FALSE(loader()->IsIdle());
+  EXPECT_FALSE(loader()->IsLoaded());
+
+  test_adapter()->GetObserver()->OnPrerenderDomContentLoaded();
+  PumpLoop();
+  EXPECT_TRUE(loader()->IsIdle());
+  EXPECT_TRUE(callback_called());
+  EXPECT_EQ(Offliner::RequestStatus::PRERENDERING_CANCELED,
+            callback_load_status());
+
+  // Stopped event causes no harm.
+  test_adapter()->GetObserver()->OnPrerenderStop();
+  PumpLoop();
+}
+
 TEST_F(PrerenderingLoaderTest, LoadPageLoadFailedUnsupportedScheme) {
-  test_adapter()->Configure(
-      nullptr /* web_contents */,
-      prerender::FinalStatus::FINAL_STATUS_UNSUPPORTED_SCHEME);
+  test_adapter()->Configure(nullptr /* web_contents */,
+                            prerender::FINAL_STATUS_UNSUPPORTED_SCHEME);
   GURL gurl("http://testit.sea");
   EXPECT_TRUE(loader()->IsIdle());
   EXPECT_TRUE(loader()->LoadPage(
       gurl,
       base::Bind(&PrerenderingLoaderTest::OnLoadDone, base::Unretained(this))));
   EXPECT_FALSE(loader()->IsIdle());
   EXPECT_FALSE(loader()->IsLoaded());
 
   test_adapter()->GetObserver()->OnPrerenderDomContentLoaded();
   PumpLoop();
@@ skipping 54 matching lines @@
   test_adapter()->FailStart();
   GURL gurl("http://testit.sea");
   EXPECT_TRUE(loader()->IsIdle());
   EXPECT_FALSE(loader()->LoadPage(
       gurl,
       base::Bind(&PrerenderingLoaderTest::OnLoadDone, base::Unretained(this))));
   EXPECT_TRUE(loader()->IsIdle());
 }
 
 }  // namespace offline_pages