Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2361873002: Revert of Relanding updates to swarming api to add chartjson output. (Closed)

Created:
4 years, 3 months ago by eyaich1
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Relanding updates to swarming api to add chartjson output. (patchset #3 id:40001 of https://codereview.chromium.org/2352413002/ ) Reason for revert: GPU tests failing on chromium tryservers (https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/302378) A fix is in the works, but will revert this until fix is in. Original issue's description: > Relanding updates to swarming api to add chartjson output. > > This updates the api to check for chartjson results from a finished task in output directory with a file named chart-output.json. > > BUG=chromium:633253 > TBR=dpranke@chromium.org > > patch from issue 2336293002 at patchset 180001 (http://crrev.com/2336293002#ps180001) > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/5762aa84bb564e0c091aafeff5fef30ae3406cf9 TBR=kbr@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:633253 Committed: https://chromium.googlesource.com/chromium/tools/build/+/f5f913204f38a678cc7463fc904935a8546b2ae2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1102 lines) Patch
M scripts/slave/recipe_modules/swarming/api.py View 5 chunks +12 lines, -70 lines 0 comments Download
M scripts/slave/recipe_modules/test_utils/test_api.py View 3 chunks +9 lines, -30 lines 0 comments Download
M scripts/slave/recipes/chromium.py View 2 chunks +1 line, -73 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json View 2 chunks +2 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_gpu.json View 3 chunks +3 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_non_gpu.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test_with_swarming_failure.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json View 1 chunk +1 line, -2 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json View 1 chunk +0 lines, -452 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json View 1 chunk +0 lines, -443 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_missing_shard.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_test.json View 2 chunks +1 line, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
eyaich1
Created Revert of Relanding updates to swarming api to add chartjson output.
4 years, 3 months ago (2016-09-22 16:59:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361873002/1
4 years, 3 months ago (2016-09-22 16:59:08 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-22 16:59:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361873002/1
4 years, 3 months ago (2016-09-22 16:59:37 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-22 16:59:39 UTC) #9
Ken Russell (switch to Gerrit)
LGTM
4 years, 3 months ago (2016-09-22 16:59:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361873002/1
4 years, 3 months ago (2016-09-22 17:00:08 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/f5f913204f38a678cc7463fc904935a8546b2ae2
4 years, 3 months ago (2016-09-22 17:00:18 UTC) #14
Dirk Pranke
4 years, 3 months ago (2016-09-22 17:10:34 UTC) #15
Message was sent while issue was closed.
lgtm ;)

Powered by Google App Engine
This is Rietveld 408576698