Always use vector icons for desktop infobars (when one is defined).

Always use vector icons for desktop infobars (when one is defined),
rather than caring about the (deprecated) material design mode.

Make IDR_INFOBAR_SAVE_PASSWORD android-only.

BUG=648281
TBR=oshima@chromium.org

Committed: https://crrev.com/8b5f8947027c3d01a8474dae08b8caf0e06fc4ea
Cr-Commit-Position: refs/heads/master@{#420748}

[Evan Stade, 2016-09-22 16:29:10]

Description was changed from

==========
Always use vector icons for desktop infobars (when one is defined).

Make IDR_INFOBAR_SAVE_PASSWORD android-only.

BUG=648281
==========

to

==========
Always use vector icons for desktop infobars (when one is defined),
rather than caring about the (deprecated) material design mode.

Make IDR_INFOBAR_SAVE_PASSWORD android-only.

BUG=648281
==========

[Evan Stade, 2016-09-22 16:29:10]

estade@chromium.org changed reviewers:
+ pkasting@chromium.org

[Evan Stade, 2016-09-22 16:30:05]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 16:30:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 17:08:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 17:08:50]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Peter Kasting, 2016-09-22 23:51:35]

This looks like it only implements the last sentence of the CL description, and
not a generalized "always use vectors for all infobars and never care about MD"?

I mean, LGTM, but I was wondering it this was just a piece of what you meant to
send.

[Evan Stade, 2016-09-23 00:39:31]

On 2016/09/22 23:51:35, Peter Kasting wrote:
> This looks like it only implements the last sentence of the CL description,
and
> not a generalized "always use vectors for all infobars and never care about
MD"?
> 
> I mean, LGTM, but I was wondering it this was just a piece of what you meant
to
> send.

yea, good call. Somehow that change got lost in the ether. Updated.

[Evan Stade, 2016-09-23 00:39:35]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 00:40:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2016-09-23 00:45:10]

https://codereview.chromium.org/2361843003/diff/40001/chrome/browser/ssl/ssl_...
File chrome/browser/ssl/ssl_add_certificate.cc (left):

https://codereview.chromium.org/2361843003/diff/40001/chrome/browser/ssl/ssl_...
chrome/browser/ssl/ssl_add_certificate.cc:91: return IDR_INFOBAR_SAVE_PASSWORD;
So, this is safe to remove because this infobar isn't used on Android/iOS?

https://codereview.chromium.org/2361843003/diff/40001/chrome/browser/ssl/ssl_...
chrome/browser/ssl/ssl_add_certificate.cc:143: IDR_INFOBAR_SAVE_PASSWORD,
(and similarly)

[Evan Stade, 2016-09-23 01:24:39]

https://codereview.chromium.org/2361843003/diff/40001/chrome/browser/ssl/ssl_...
File chrome/browser/ssl/ssl_add_certificate.cc (left):

https://codereview.chromium.org/2361843003/diff/40001/chrome/browser/ssl/ssl_...
chrome/browser/ssl/ssl_add_certificate.cc:143: IDR_INFOBAR_SAVE_PASSWORD,
On 2016/09/23 00:45:09, Peter Kasting wrote:
> (and similarly)

yes, this file isn't compiled on mobile.

[Peter Kasting, 2016-09-23 01:28:59]

Cool, LGTM

[commit-bot: I haz the power, 2016-09-23 01:29:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 01:29:10]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-09-23 01:39:00]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-09-23 01:39:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 01:49:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 01:49:26]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Evan Stade, 2016-09-23 16:48:05]

estade@chromium.org changed reviewers:
+ felt@chromium.org, oshima@chromium.org

[Evan Stade, 2016-09-23 16:48:05]

+felt and +oshima for OWNERS

[Evan Stade, 2016-09-23 16:48:18]

Description was changed from

==========
Always use vector icons for desktop infobars (when one is defined),
rather than caring about the (deprecated) material design mode.

Make IDR_INFOBAR_SAVE_PASSWORD android-only.

BUG=648281
==========

to

==========
Always use vector icons for desktop infobars (when one is defined),
rather than caring about the (deprecated) material design mode.

Make IDR_INFOBAR_SAVE_PASSWORD android-only.

BUG=648281
TBR=oshima@chromium.org
==========

[felt, 2016-09-23 17:05:41]

lgtm

[Evan Stade, 2016-09-23 21:50:56]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-09-23 21:51:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 22:39:26]

Description was changed from

==========
Always use vector icons for desktop infobars (when one is defined),
rather than caring about the (deprecated) material design mode.

Make IDR_INFOBAR_SAVE_PASSWORD android-only.

BUG=648281
TBR=oshima@chromium.org
==========

to

==========
Always use vector icons for desktop infobars (when one is defined),
rather than caring about the (deprecated) material design mode.

Make IDR_INFOBAR_SAVE_PASSWORD android-only.

BUG=648281
TBR=oshima@chromium.org
==========

[commit-bot: I haz the power, 2016-09-23 22:39:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-23 22:42:29]

Description was changed from

==========
Always use vector icons for desktop infobars (when one is defined),
rather than caring about the (deprecated) material design mode.

Make IDR_INFOBAR_SAVE_PASSWORD android-only.

BUG=648281
TBR=oshima@chromium.org
==========

to

==========
Always use vector icons for desktop infobars (when one is defined),
rather than caring about the (deprecated) material design mode.

Make IDR_INFOBAR_SAVE_PASSWORD android-only.

BUG=648281
TBR=oshima@chromium.org

Committed: https://crrev.com/8b5f8947027c3d01a8474dae08b8caf0e06fc4ea
Cr-Commit-Position: refs/heads/master@{#420748}
==========

[commit-bot: I haz the power, 2016-09-23 22:42:30]

Patchset 3 (id:??) landed as
https://crrev.com/8b5f8947027c3d01a8474dae08b8caf0e06fc4ea
Cr-Commit-Position: refs/heads/master@{#420748}