Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 236183004: Get horizontal wheel scrolling working again with logitech drivers. (Closed)

Created:
6 years, 8 months ago by ananta
Modified:
6 years, 8 months ago
Reviewers:
cpu_(ooo_6.6-7.5), sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Get horizontal wheel scrolling working again with logitech drivers. Some Logitech drivers send WM_MOUSEHWHEEL messages to the parent window intermingled with WM_MOUSEWHEEL messages to the child if there is one. This causes horizontal scrolling to be treated as vertical scroll. Hack is to remember the last time a WM_MOUSEHWHEEL message is received and treat WM_MOUSEWHEEL messages which occur in this window as WM_MOUSEHWHEEL messages. BUG=332797 R=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263667

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M ui/views/win/hwnd_message_handler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
ananta
6 years, 8 months ago (2014-04-12 01:46:11 UTC) #1
sky
LGTM
6 years, 8 months ago (2014-04-14 14:53:03 UTC) #2
ananta
The CQ bit was checked by ananta@chromium.org
6 years, 8 months ago (2014-04-14 16:14:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/236183004/1
6 years, 8 months ago (2014-04-14 16:14:36 UTC) #4
ananta
The CQ bit was unchecked by ananta@chromium.org
6 years, 8 months ago (2014-04-14 16:15:17 UTC) #5
ananta
The CQ bit was checked by ananta@chromium.org
6 years, 8 months ago (2014-04-14 16:15:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/236183004/1
6 years, 8 months ago (2014-04-14 16:15:55 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 18:05:20 UTC) #8
Message was sent while issue was closed.
Change committed as 263667

Powered by Google App Engine
This is Rietveld 408576698