Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2361813004: Mojo Java bindings: org.chromium.mojom -> org.chromium (Closed)

Created:
4 years, 3 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 3 months ago
Reviewers:
haraken, yzshen1
CC:
Aaron Boodman, abarth-chromium, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, jam, mlamouri+watch-sensors_chromium.org, ntp-dev+reviews_chromium.org, qsr+mojo_chromium.org, riju_, timvolodine, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo Java bindings: org.chromium.mojom -> org.chromium Changes generated module packages to use this shorter prefix. Updates the explicit org.chromium.mojom.payments and org.chromium.mojom.webshare packages accordingly. Also moves device.nfc mojom definitions to device.nfc.mojom. BUG=None R=yzshen@chromium.org TBR=tedchoc@chromium.org,alexander.shalamov@intel.com Committed: https://crrev.com/4738908517766fe95a63a764456104437fffc744 Cr-Commit-Position: refs/heads/master@{#420429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -97 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeInterfaceRegistrar.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestFactory.java View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 2 chunks +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImplementationFactory.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/payments/AutofillAddressTest.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrar.java View 1 chunk +3 lines, -3 lines 0 comments Download
M device/battery/android/java/src/org/chromium/device/battery/BatteryMonitorFactory.java View 1 chunk +2 lines, -2 lines 0 comments Download
M device/battery/android/java/src/org/chromium/device/battery/BatteryMonitorImpl.java View 1 chunk +2 lines, -2 lines 0 comments Download
M device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java View 1 chunk +1 line, -1 line 0 comments Download
M device/battery/android/javatests/src/org/chromium/device/battery/BatteryStatusManagerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M device/generic_sensor/android/java/src/org/chromium/device/sensors/PlatformSensor.java View 1 chunk +1 line, -1 line 0 comments Download
M device/generic_sensor/android/java/src/org/chromium/device/sensors/PlatformSensorProvider.java View 1 chunk +1 line, -1 line 0 comments Download
M device/generic_sensor/android/junit/src/org/chromium/device/sensors/PlatformSensorAndProviderTest.java View 1 chunk +3 lines, -3 lines 0 comments Download
M device/nfc/android/java/src/org/chromium/device/nfc/NfcImpl.java View 1 chunk +8 lines, -8 lines 0 comments Download
M device/nfc/android/java/src/org/chromium/device/nfc/NfcTypeConverter.java View 2 chunks +4 lines, -4 lines 0 comments Download
M device/nfc/nfc.mojom View 2 chunks +3 lines, -2 lines 0 comments Download
M device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/mojom_java_generator.py View 1 chunk +2 lines, -2 lines 0 comments Download
M services/shell/public/java/src/org/chromium/services/shell/InterfaceRegistry.java View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFC.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFC.cpp View 9 chunks +23 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFCError.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFCError.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/payments/payment_request.mojom View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/webshare/webshare.mojom View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Ken Rockot(use gerrit already)
4 years, 3 months ago (2016-09-22 17:32:39 UTC) #1
yzshen1
lgtm
4 years, 3 months ago (2016-09-22 18:12:37 UTC) #4
Ken Rockot(use gerrit already)
TBRing other owners, just some renames FYI
4 years, 3 months ago (2016-09-22 18:30:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361813004/1
4 years, 3 months ago (2016-09-22 18:31:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 19:42:28 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4738908517766fe95a63a764456104437fffc744 Cr-Commit-Position: refs/heads/master@{#420429}
4 years, 3 months ago (2016-09-22 19:46:11 UTC) #12
haraken
WebKit/Source LGTM
4 years, 3 months ago (2016-09-22 23:41:11 UTC) #13
Michael van Ouwerkerk
4 years, 3 months ago (2016-09-23 10:17:29 UTC) #14
Message was sent while issue was closed.
On 2016/09/22 23:41:11, haraken wrote:
> WebKit/Source LGTM

FYI: this broke downstream Chrome for Android compilation. Not strictly your
reponsibility as it is a downstream repo, but please keep this in mind as a
possibility for next time :-)

Powered by Google App Engine
This is Rietveld 408576698