Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2361813003: Fix test.py and tests to use an explicit --packages flag. (Closed)

Created:
4 years, 3 months ago by Bill Hesse
Modified:
4 years, 3 months ago
Reviewers:
Johnni Winther, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix test.py and tests to use an explicit --packages flag. BUG=https://github.com/dart-lang/sdk/issues/27412 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/92cd3e10f5c651f34f83c4424c4692f8410b7360

Patch Set 1 #

Patch Set 2 : Handle case where only observatory_ui tests are run. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -33 lines) Patch
M pkg/analysis_server/test/integration/integration_tests.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/tool/task_dependency_graph/generate.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/observatory_ui.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/standalone/io/skipping_dart2js_compilations_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/io/test_runner_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/standalone/package/scenarios/empty_packages_file/empty_packages_file_noimports_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/standalone/package/scenarios/empty_packages_file/empty_packages_file_option_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/standalone/package/scenarios/invalid/invalid_package_name_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/standalone/package/scenarios/invalid/invalid_utf8_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/standalone/package/scenarios/invalid/non_existent_packages_file_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/standalone/package/scenarios/invalid/same_package_twice_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/standalone/package/scenarios/packages_file_strange_formatting/empty_lines_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/standalone/package/scenarios/packages_file_strange_formatting/empty_package_dir_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/standalone/package/scenarios/packages_file_strange_formatting/mixed_line_ends_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/standalone/package/scenarios/packages_option_only/packages_option_only_noimports_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/standalone/package/scenarios/packages_option_only/packages_option_only_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tools/test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_options.dart View 1 1 chunk +34 lines, -0 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 3 chunks +25 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
4 years, 3 months ago (2016-09-22 15:37:19 UTC) #2
Cutch
LGTM
4 years, 3 months ago (2016-09-22 15:46:45 UTC) #3
Bill Hesse
4 years, 3 months ago (2016-09-22 15:51:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
92cd3e10f5c651f34f83c4424c4692f8410b7360 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698