Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 23618061: Map Calibri to Carlito (Closed)

Created:
7 years, 3 months ago by jungshik at Google
Modified:
7 years, 3 months ago
Reviewers:
bungeman-skia
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Map Calibri to Carlito Chrome OS will have Carlito as a metric-compatible replacement for Calibri. This change has to be combined with a Chrome OS change to add Calibri and configure fontconfig accordingly. BUG=280557 TEST=With the CrOS change, a page using Calibri will use Carlito instead of the default fallback font (Arimo in case of English UI). R=bungeman@google.com Committed: https://code.google.com/p/skia/source/detail?r=11418

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/ports/SkFontConfigInterface_direct.cpp View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jungshik at Google
Hi, Can you LGTM here again? I made a separate check out of Skia outside ...
7 years, 3 months ago (2013-09-19 20:09:18 UTC) #1
bungeman-skia
lgtm
7 years, 3 months ago (2013-09-19 20:38:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jshin@chromium.org/23618061/1
7 years, 3 months ago (2013-09-20 16:25:18 UTC) #3
commit-bot: I haz the power
Retried try job too often on Build-Mac10.7-Clang-x86-Release-Trybot for step(s) BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests, BuildTools ...
7 years, 3 months ago (2013-09-20 16:29:16 UTC) #4
jungshik at Google
On 2013/09/20 16:29:16, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 3 months ago (2013-09-20 16:48:06 UTC) #5
bungeman-skia
Committed patchset #1 manually as r11418 (presubmit successful).
7 years, 3 months ago (2013-09-20 17:43:05 UTC) #6
bungeman-skia
Sorry about this being such a pain to get though the commit queue. We haven't ...
7 years, 3 months ago (2013-09-20 17:45:17 UTC) #7
jungshik at Google
7 years, 3 months ago (2013-09-20 22:29:31 UTC) #8
Message was sent while issue was closed.
On 2013/09/20 17:45:17, bungeman1 wrote:
> Sorry about this being such a pain to get though the commit queue. We haven't
> really been working on making the current process much easier because we're
> planning on transitioning to a git repo, and having a full checkout in
Chromium.

Oh. Thank you !!

Powered by Google App Engine
This is Rietveld 408576698