Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 23618056: Move NumberToStringStub::GenerateLookupNumberStringCache to the MacroAssembler. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer
Modified:
7 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Move NumberToStringStub::GenerateLookupNumberStringCache to the MacroAssembler. This renames the method to LookupNumberStringCache() and puts it into the MacroAssembler in preparation of the NumberToStringStub Hydrogen conversion. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16806

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -346 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M src/arm/code-stubs-arm.h View 1 chunk +0 lines, -13 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 2 chunks +2 lines, -94 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +82 lines, -0 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +2 lines, -92 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +11 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +82 lines, -0 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M src/x64/code-stubs-x64.h View 1 chunk +0 lines, -16 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +2 lines, -97 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +11 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +84 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Hey Michael, As discussed offline, I've split the NumberToStringStub conversion CL into separate CLs. This ...
7 years, 3 months ago (2013-09-18 11:08:43 UTC) #1
mvstanton
A very nice re-arrangement :^). lgtm.
7 years, 3 months ago (2013-09-18 15:59:17 UTC) #2
Benedikt Meurer
7 years, 3 months ago (2013-09-19 06:07:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16806 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698