Source/web/ContextMenuClientImpl.cpp - Issue 23618052: TextBreakIterator should use the C++ icu API instead of the C one

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ContextMenuClientImpl.cpp

Issue 23618052: TextBreakIterator should use the C++ icu API instead of the C one (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Downcast to icu::RuleBasedBreakIterator Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ContextMenuClientImpl.cpp

diff --git a/Source/web/ContextMenuClientImpl.cpp b/Source/web/ContextMenuClientImpl.cpp

index 112d4f4ca9dc3aa52e674e4ef893d81970908ba6..3f3cb0c1f5c7a57cff5312e2edf01b2ed7fa79ae 100644

--- a/Source/web/ContextMenuClientImpl.cpp

+++ b/Source/web/ContextMenuClientImpl.cpp

@@ -100,7 +100,7 @@ static WebURL urlFromFrame(Frame* frame)

static bool isASingleWord(const String& text)

{

TextBreakIterator* it = wordBreakIterator(text, 0, text.length());

- return it && textBreakNext(it) == static_cast<int>(text.length());

+ return it && it->next() == static_cast<int>(text.length());

}

// Helper function to get misspelled word on which context menu

« no previous file with comments | « Source/platform/text/TextBreakIteratorICU.cpp ('k') | Source/wtf/unicode/icu/UnicodeIcu.h » ('j') | no next file with comments »