Source/core/rendering/break_lines.cpp - Issue 23618052: TextBreakIterator should use the C++ icu API instead of the C one

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/break_lines.cpp

Issue 23618052: TextBreakIterator should use the C++ icu API instead of the C one (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Downcast to icu::RuleBasedBreakIterator Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/break_lines.cpp

diff --git a/Source/core/rendering/break_lines.cpp b/Source/core/rendering/break_lines.cpp

index 8ecc8d40ccd6e2a4bca3c2130540908170171cdc..949e1ba4edc010e3dbf7f09b1d564f86a80fb579 100644

--- a/Source/core/rendering/break_lines.cpp

+++ b/Source/core/rendering/break_lines.cpp

@@ -164,7 +164,7 @@ static inline int nextBreakablePosition(LazyLineBreakIterator& lazyBreakIterator

if (i || priorContextLength) {

TextBreakIterator* breakIterator = lazyBreakIterator.get(priorContextLength);

if (breakIterator) {

- nextBreak = textBreakFollowing(breakIterator, i - 1 + priorContextLength);

+ nextBreak = breakIterator->following(i - 1 + priorContextLength);

if (nextBreak >= 0) {

nextBreak -= priorContextLength;

}

« no previous file with comments | « Source/core/rendering/RenderText.cpp ('k') | Source/platform/text/TextBoundaries.cpp » ('j') | no next file with comments »