Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: content/public/browser/notification_types.h

Issue 23618036: Merge NOTIFICATION_RENDER_VIEW_HOST_CHANGED into NOTIFICATION_WEB_CONTENTS_SWAPPED. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/notification_types.h
diff --git a/content/public/browser/notification_types.h b/content/public/browser/notification_types.h
index 549c8710f65f4737f8f00507281ebb757ede0960..c3b5f2e57828345a06c9ca94a4758d6f9e3e2a8b 100644
--- a/content/public/browser/notification_types.h
+++ b/content/public/browser/notification_types.h
@@ -119,12 +119,10 @@ enum NotificationType {
// This notification is sent when a WebContents swaps its render view host
// with another one, possibly changing processes. The source is a
- // Source<WebContents> with a pointer to the WebContents. A
- // NOTIFICATION_WEB_CONTENTS_DISCONNECTED notification is guaranteed before
- // the source pointer becomes junk. Details are the RenderViewHost that
- // has been replaced, or NULL if the old RVH was shut down.
- // DEPRECATED: Use WebContentsObserver::RenderViewHostSwapped()
- NOTIFICATION_WEB_CONTENTS_SWAPPED,
+ // Source<WebContents> with a pointer to the WebContents, details is a
+ // std::pair::<old RenderViewHost, new RenderViewHost>.
+ // DEPRECATED: Use WebContentsObserver::RenderViewHostChanged()
+ NOTIFICATION_RENDER_VIEW_HOST_CHANGED,
// This message is sent after a WebContents is disconnected from the
// renderer process. The source is a Source<WebContents> with a pointer to
@@ -183,12 +181,6 @@ enum NotificationType {
// hung view, and no details are expected.
NOTIFICATION_RENDERER_PROCESS_HANG,
- // This is sent to notify that the RenderViewHost displayed in a WebContents
- // has changed. Source is the NavigationController for which the change
- // happened, details is a
- // std::pair::<old RenderViewHost, new RenderViewHost>).
- NOTIFICATION_RENDER_VIEW_HOST_CHANGED,
-
// This is sent when a RenderWidgetHost is being destroyed. The source is
// the RenderWidgetHost, the details are not used.
NOTIFICATION_RENDER_WIDGET_HOST_DESTROYED,

Powered by Google App Engine
This is Rietveld 408576698