Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1967)

Unified Diff: chrome/browser/ui/panels/panel.cc

Issue 23618036: Merge NOTIFICATION_RENDER_VIEW_HOST_CHANGED into NOTIFICATION_WEB_CONTENTS_SWAPPED. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel.cc
diff --git a/chrome/browser/ui/panels/panel.cc b/chrome/browser/ui/panels/panel.cc
index 4189284ab194843e8adf55623b11bfeb8127f490..2b21bc73f4f2b5bdb2e9d6190b7557d6ec4e2d37 100644
--- a/chrome/browser/ui/panels/panel.cc
+++ b/chrome/browser/ui/panels/panel.cc
@@ -150,7 +150,7 @@ bool PanelExtensionWindowController::IsVisibleToExtension(
return extension->id() == panel_->extension_id();
}
-} // namespace internal
+} // namespace panel_internal
Panel::~Panel() {
DCHECK(!collection_);
@@ -431,7 +431,7 @@ void Panel::Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) {
switch (type) {
- case content::NOTIFICATION_WEB_CONTENTS_SWAPPED:
+ case content::NOTIFICATION_RENDER_VIEW_HOST_CHANGED:
ConfigureAutoResize(content::Source<content::WebContents>(source).ptr());
break;
case chrome::NOTIFICATION_EXTENSION_UNLOADED:
@@ -582,7 +582,7 @@ void Panel::SetAutoResizable(bool resizable) {
EnableWebContentsAutoResize(web_contents);
} else {
if (web_contents) {
- registrar_.Remove(this, content::NOTIFICATION_WEB_CONTENTS_SWAPPED,
+ registrar_.Remove(this, content::NOTIFICATION_RENDER_VIEW_HOST_CHANGED,
content::Source<content::WebContents>(web_contents));
// NULL might be returned if the tab has not been added.
@@ -600,11 +600,11 @@ void Panel::EnableWebContentsAutoResize(content::WebContents* web_contents) {
// We also need to know when the render view host changes in order
// to turn on auto-resize notifications in the new render view host.
if (!registrar_.IsRegistered(
- this, content::NOTIFICATION_WEB_CONTENTS_SWAPPED,
+ this, content::NOTIFICATION_RENDER_VIEW_HOST_CHANGED,
content::Source<content::WebContents>(web_contents))) {
registrar_.Add(
this,
- content::NOTIFICATION_WEB_CONTENTS_SWAPPED,
+ content::NOTIFICATION_RENDER_VIEW_HOST_CHANGED,
content::Source<content::WebContents>(web_contents));
}
}
« no previous file with comments | « chrome/browser/ui/gtk/apps/native_app_window_gtk.cc ('k') | chrome/browser/ui/views/apps/native_app_window_views.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698