content/browser/web_contents/web_contents_impl.h - Issue 23618036: Merge NOTIFICATION_RENDER_VIEW_HOST_CHANGED into NOTIFICATION_WEB_CONTENTS_SWAPPED.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 23618036: Merge NOTIFICATION_RENDER_VIEW_HOST_CHANGED into NOTIFICATION_WEB_CONTENTS_SWAPPED. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/content_view_core_impl.cc ('K') | « content/browser/web_contents/render_view_host_manager_unittest.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index b96e9b5ea6cfe5217691e154a0be3cc0f0b6ca57..da931e9f9ed838c2424f5fad9ffa64d0e90b8bf5 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -494,7 +494,7 @@ class CONTENT_EXPORT WebContentsImpl

RenderViewHost* render_view_host) OVERRIDE;

virtual void UpdateRenderViewSizeForRenderManager() OVERRIDE;

virtual void NotifySwappedFromRenderManager(

- RenderViewHost* old_render_view_host) OVERRIDE;

+ RenderViewHost* old_host, RenderViewHost* new_host) OVERRIDE;

virtual int CreateOpenerRenderViewsForRenderManager(

SiteInstance* instance) OVERRIDE;

virtual NavigationControllerImpl&

@@ -744,7 +744,7 @@ class CONTENT_EXPORT WebContentsImpl

// Misc non-view stuff -------------------------------------------------------

// Helper functions for sending notifications.

- void NotifySwapped(RenderViewHost* old_render_view_host);

+ void NotifySwapped(RenderViewHost* old_host, RenderViewHost* new_host);

void NotifyDisconnected();

void NotifyNavigationEntryCommitted(const LoadCommittedDetails& load_details);