Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2009)

Issue 2361803002: Avoid unnecessary checking in getting current time on 32-bit systems. (Closed)

Created:
3 years ago by chihchung
Modified:
3 years ago
Reviewers:
wuchengli, miu
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid unnecessary checking in getting current time on 32-bit systems. In ConvertTimespecToMicros(), int64_t is large enough to keep 32-bit time values in microseconds. The arithmetic checking for multiplication involves 64-bit division and can be slow. ConvertTimespecToMicros() is used by ClockNow(), and that can be used often. Committed: https://crrev.com/39e5faa419bfce4aee5172cf32c760180d698810 Cr-Commit-Position: refs/heads/master@{#422390}

Patch Set 1 #

Patch Set 2 : update comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M base/time/time_posix.cc View 1 1 chunk +13 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
miu
lgtm
3 years ago (2016-09-28 23:09:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361803002/20001
3 years ago (2016-10-03 07:04:45 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years ago (2016-10-03 08:29:57 UTC) #11
commit-bot: I haz the power
3 years ago (2016-10-03 08:31:21 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/39e5faa419bfce4aee5172cf32c760180d698810
Cr-Commit-Position: refs/heads/master@{#422390}

Powered by Google App Engine
This is Rietveld 408576698