Issue 23618029: [SyncFS] Implement Database initialization part of SyncEngineInitializer

Issue 23618029: [SyncFS] Implement Database initialization part of SyncEngineInitializer (Closed)

Created:
7 years, 3 months ago by tzik

Modified:
7 years, 3 months ago

Reviewers:
kinuko, nhiroki

CC:
chromium-reviews, nhiroki+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[SyncFS] Implement Database initialization part of SyncEngineInitializer BUG=240165 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221383

Patch Set 2 : +comment, +error check #

Patch Set 3 : +DriveAPIService dependency #

Total comments: 2

Patch Set 4 : rebase, commint fix #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -5 lines)			Patch
M	chrome/browser/sync_file_system/drive_backend/sync_engine.h	View		3 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/sync_engine.cc	View	1 2	2 chunks	+12 lines, -1 line	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.h	View	1 2	1 chunk	+25 lines, -1 line	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc	View	1 2 3	2 chunks	+30 lines, -2 lines	0 comments	Download
M	chrome/browser/sync_file_system/sync_file_system_service_factory.cc	View	1 2 3	2 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

nhiroki

lgtm (sorry for my delayed response) https://codereview.chromium.org/23618029/diff/5001/chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc File chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc (right): https://codereview.chromium.org/23618029/diff/5001/chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc#newcode47 chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc:47: // TODO(tzik): Set ...

7 years, 3 months ago (2013-09-05 08:21:00 UTC) #3

tzik

Thanks! https://codereview.chromium.org/23618029/diff/5001/chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc File chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc (right): https://codereview.chromium.org/23618029/diff/5001/chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc#newcode47 chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc:47: // TODO(tzik): Set up sync root and populate ...

7 years, 3 months ago (2013-09-05 08:32:55 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/23618029/5001

7 years, 3 months ago (2013-09-05 08:33:35 UTC) #5

commit-bot: I haz the power

Failed to trigger a try job on chromium_presubmit HTTP Error 400: Bad Request

7 years, 3 months ago (2013-09-05 08:33:40 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/23618029/18001

7 years, 3 months ago (2013-09-05 08:33:57 UTC) #7

Message was sent while issue was closed.

Change committed as 221383

Expand Messages | Collapse Messages