[Files.app] Refile a timing of doing selectBestMatchItem().

chrome/browser/resources/file_manager/js/navigation_list.js

Index: chrome/browser/resources/file_manager/js/navigation_list.js
diff --git a/chrome/browser/resources/file_manager/js/navigation_list.js b/chrome/browser/resources/file_manager/js/navigation_list.js
index 8fa40e9911ee69113b31bc83c125050027eb63c7..79b346facf87707581f4f866989ce1029cb88bd1 100644
--- a/chrome/browser/resources/file_manager/js/navigation_list.js
+++ b/chrome/browser/resources/file_manager/js/navigation_list.js
@@ -450,15 +450,19 @@ NavigationList.prototype = {
       this.boundHandleListChanged_ = this.onListContentChanged_.bind(this);
 
     if (this.dataModel_) {
-      dataModel.removeEventListener('change', this.boundHandleListChanged_);
-      dataModel.removeEventListener('permuted', this.boundHandleListChanged_);
+      this.dataModel_.removeEventListener(
+          'change', this.boundHandleListChanged_);

[hirono, 2013/09/04 13:39:25]

nit: The name pattern of xxxBound is more likely to use in Files.app.

https://code.google.com/p/chromium/codesearch#search/&q=on%5Ba-zA-Z%5D%2BBoun...

[yoshiki, 2013/09/04 14:26:55]

Done.

+      this.dataModel_.removeEventListener(
+          'permuted', this.boundHandleListChanged_);
     }
 
+    var parentSetter = cr.ui.List.prototype.__lookupSetter__('dataModel');
+    parentSetter.call(this, dataModel);
+
+    // This must be placed after the parent method is called, in order to make
+    // it sure that the list was changed.
     dataModel.addEventListener('change', this.boundHandleListChanged_);
     dataModel.addEventListener('permuted', this.boundHandleListChanged_);
-
-    var parentSetter = cr.ui.List.prototype.__lookupSetter__('dataModel');
-    return parentSetter.call(this, dataModel);
   },
 
   get dataModel() {