[Files.app] Refile a timing of doing selectBestMatchItem().

chrome/browser/resources/file_manager/js/navigation_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * Entry of NavigationListModel. This construtor should be called only from
  * the helper methods (NavigationModelItem.createWithPath/createWithEntry).
  *
@@ skipping 432 matching lines @@
  * NavigationList inherits cr.ui.List.
  */
 NavigationList.prototype = {
   __proto__: cr.ui.List.prototype,
 
   set dataModel(dataModel) {
     if (!this.boundHandleListChanged_)
       this.boundHandleListChanged_ = this.onListContentChanged_.bind(this);
 
     if (this.dataModel_) {
-      dataModel.removeEventListener('change', this.boundHandleListChanged_);
-      dataModel.removeEventListener('permuted', this.boundHandleListChanged_);
+      this.dataModel_.removeEventListener(
+          'change', this.boundHandleListChanged_);

[hirono, 2013/09/04 13:39:25]

nit: The name pattern of xxxBound is more likely to use in Files.app.

https://code.google.com/p/chromium/codesearch#search/&q=on%5Ba-zA-Z%5D%2BBoun...

[yoshiki, 2013/09/04 14:26:55]

Done.

+      this.dataModel_.removeEventListener(
+          'permuted', this.boundHandleListChanged_);
     }
 
+    var parentSetter = cr.ui.List.prototype.__lookupSetter__('dataModel');
+    parentSetter.call(this, dataModel);
+
+    // This must be placed after the parent method is called, in order to make
+    // it sure that the list was changed.
     dataModel.addEventListener('change', this.boundHandleListChanged_);
     dataModel.addEventListener('permuted', this.boundHandleListChanged_);
-
-    var parentSetter = cr.ui.List.prototype.__lookupSetter__('dataModel');
-    return parentSetter.call(this, dataModel);
   },
 
   get dataModel() {
     return this.dataModel_;
   },
 
   // TODO(yoshiki): Add a setter of 'directoryModel'.
 };
 
 /**
@@ skipping 265 matching lines @@
     var itemPath = this.dataModel.item(i).path;
     if (PathUtil.getRootPath(itemPath) == newRootPath) {
       // Not to invoke the handler of this instance, sets the guard.
       this.dontHandleSelectionEvent_ = true;
       this.selectionModel.selectedIndex = i;
       this.dontHandleSelectionEvent_ = false;
       return;
     }
   }
 };