[Files.app] Refile a timing of doing selectBestMatchItem().

chrome/browser/resources/file_manager/js/navigation_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * Entry of NavigationListModel. This construtor should be called only from
  * the helper methods (NavigationModelItem.createWithPath/createWithEntry).
  *
@@ skipping 428 matching lines @@
 function NavigationList() {
 }
 
 /**
  * NavigationList inherits cr.ui.List.
  */
 NavigationList.prototype = {
   __proto__: cr.ui.List.prototype,
 
   set dataModel(dataModel) {
-    if (!this.boundHandleListChanged_)
-      this.boundHandleListChanged_ = this.onListContentChanged_.bind(this);
-
-    if (this.dataModel_) {
-      dataModel.removeEventListener('change', this.boundHandleListChanged_);
-      dataModel.removeEventListener('permuted', this.boundHandleListChanged_);
-    }
-
-    dataModel.addEventListener('change', this.boundHandleListChanged_);
-    dataModel.addEventListener('permuted', this.boundHandleListChanged_);
-
     var parentSetter = cr.ui.List.prototype.__lookupSetter__('dataModel');
     return parentSetter.call(this, dataModel);
   },
 
   get dataModel() {
     return this.dataModel_;
   },
 
   // TODO(yoshiki): Add a setter of 'directoryModel'.
 };
@@ skipping 215 matching lines @@
 /**
  * Invoked when the current directory is changed.
  * @param {Event} event The event.
  * @private
  */
 NavigationList.prototype.onCurrentDirectoryChanged_ = function(event) {
   this.selectBestMatchItem_();
 };
 
 /**
- * Invoked when the content in the data model is changed.
- * @param {Event} event The event.
+ * Redraw the list.
+ * @override
+ */
+NavigationList.prototype.redraw = function() {
+  // Calls the parent class method.
+  cr.ui.List.prototype.redraw.call(this);
+  this.onListContentChanged_();

[hirono, 2013/09/03 09:47:21]

It seems that the redraw event is raised at the scroll event.
Does calling onListContentChanged_ for all the scroll event look heavy?

[yoshiki, 2013/09/04 13:21:11]

Thanks for good catching. I've found it can be fixed by changing the order of
registering handlers.

+};
+
+/**
+ * Invoked when the elements in the list is updated.
  * @private
  */
-NavigationList.prototype.onListContentChanged_ = function(event) {
+NavigationList.prototype.onListContentChanged_ = function() {
   this.selectBestMatchItem_();
 };
 
 /**
  * Synchronizes the volume list selection with the current directory, after
  * it is changed outside of the volume list.
  * @private
  */
 NavigationList.prototype.selectBestMatchItem_ = function() {
+  if (!this.dataModel)
+    return;
+
   var entry = this.directoryModel_.getCurrentDirEntry();
   var path = entry && entry.fullPath;
   if (!path)
     return;
 
   // (1) Select the nearest parent directory (including the shortcut folders).
   var bestMatchIndex = -1;
   var bestMatchSubStringLen = 0;
   for (var i = 0; i < this.dataModel.length; i++) {
     var itemPath = this.dataModel.item(i).path;
@@ skipping 18 matching lines @@
     var itemPath = this.dataModel.item(i).path;
     if (PathUtil.getRootPath(itemPath) == newRootPath) {
       // Not to invoke the handler of this instance, sets the guard.
       this.dontHandleSelectionEvent_ = true;
       this.selectionModel.selectedIndex = i;
       this.dontHandleSelectionEvent_ = false;
       return;
     }
   }
 };