Source/core/dom/Element.cpp - Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.cpp

Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: ASSERT on ownerElement->widget() == this causes many tests to fail. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Element.cpp

diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp

index a6b39309d378a1a0f37d402179ab6fbb6e090138..c82371d52656d4d3c7f9b811b92d6685553edab1 100644

--- a/Source/core/dom/Element.cpp

+++ b/Source/core/dom/Element.cpp

@@ -91,7 +91,6 @@

#include "core/rendering/FlowThreadController.h"

#include "core/rendering/RenderNamedFlowFragment.h"

#include "core/rendering/RenderView.h"

-#include "core/rendering/RenderWidget.h"

#include "core/svg/SVGDocumentExtensions.h"

#include "core/svg/SVGElement.h"

#include "wtf/BitVector.h"

@@ -1434,7 +1433,7 @@ void Element::unregisterNamedFlowContentNode()

void Element::detach(const AttachContext& context)

{

- RenderWidget::UpdateSuspendScope suspendWidgetHierarchyUpdates;

+ HTMLFrameOwnerElement::UpdateSuspendScope suspendWidgetHierarchyUpdates;

unregisterNamedFlowContentNode();

cancelFocusAppearanceUpdate();

removeCallbackSelectors();